From 535cee4fbd5e00999938c18497a16d8ca2eae7bd Mon Sep 17 00:00:00 2001 From: Craig Tiller Date: Fri, 29 Apr 2022 14:35:22 -0700 Subject: [PATCH] [iwyu] Enable --no_fwd_decls on iwyu script (#29527) * Flag flip * Fixups --- src/core/lib/promise/activity.cc | 2 +- src/core/lib/promise/arena_promise.h | 8 ++++++++ src/core/lib/promise/call_push_pull.h | 4 ++++ src/core/lib/promise/detail/basic_seq.h | 2 ++ src/core/lib/promise/loop.h | 1 + src/core/lib/promise/observable.h | 1 + src/core/lib/promise/pipe.h | 1 + src/core/lib/promise/sleep.cc | 2 ++ src/core/lib/promise/sleep.h | 10 ++++++++++ src/core/lib/promise/try_seq.h | 2 ++ src/core/lib/promise/wait_set.h | 1 + tools/dockerfile/grpc_iwyu/iwyu.sh | 2 +- 12 files changed, 34 insertions(+), 2 deletions(-) diff --git a/src/core/lib/promise/activity.cc b/src/core/lib/promise/activity.cc index adb35272264..f359f4eb789 100644 --- a/src/core/lib/promise/activity.cc +++ b/src/core/lib/promise/activity.cc @@ -16,7 +16,7 @@ #include "src/core/lib/promise/activity.h" -#include "absl/base/attributes.h" +#include #include "src/core/lib/gprpp/atomic_utils.h" diff --git a/src/core/lib/promise/arena_promise.h b/src/core/lib/promise/arena_promise.h index 14db9843d9e..812b5639d21 100644 --- a/src/core/lib/promise/arena_promise.h +++ b/src/core/lib/promise/arena_promise.h @@ -17,8 +17,16 @@ #include +#include + +#include +#include + +#include "absl/meta/type_traits.h" + #include +#include "src/core/lib/promise/context.h" #include "src/core/lib/promise/poll.h" #include "src/core/lib/resource_quota/arena.h" diff --git a/src/core/lib/promise/call_push_pull.h b/src/core/lib/promise/call_push_pull.h index a56496002f1..9c68f259115 100644 --- a/src/core/lib/promise/call_push_pull.h +++ b/src/core/lib/promise/call_push_pull.h @@ -19,6 +19,10 @@ #include +#include + +#include "absl/types/variant.h" + #include "src/core/lib/gprpp/bitset.h" #include "src/core/lib/gprpp/construct_destruct.h" #include "src/core/lib/promise/detail/promise_like.h" diff --git a/src/core/lib/promise/detail/basic_seq.h b/src/core/lib/promise/detail/basic_seq.h index d3029f10ee1..3e9ef2bce11 100644 --- a/src/core/lib/promise/detail/basic_seq.h +++ b/src/core/lib/promise/detail/basic_seq.h @@ -21,6 +21,7 @@ #include #include #include +#include #include #include "absl/meta/type_traits.h" @@ -29,6 +30,7 @@ #include "src/core/lib/gprpp/construct_destruct.h" #include "src/core/lib/promise/detail/promise_factory.h" +#include "src/core/lib/promise/detail/promise_like.h" #include "src/core/lib/promise/detail/switch.h" #include "src/core/lib/promise/poll.h" diff --git a/src/core/lib/promise/loop.h b/src/core/lib/promise/loop.h index 3de266727c3..0a7c07fb6f7 100644 --- a/src/core/lib/promise/loop.h +++ b/src/core/lib/promise/loop.h @@ -20,6 +20,7 @@ #include #include +#include "absl/status/status.h" #include "absl/status/statusor.h" #include "absl/types/variant.h" diff --git a/src/core/lib/promise/observable.h b/src/core/lib/promise/observable.h index 793f4c5a5fd..fe3452dca4e 100644 --- a/src/core/lib/promise/observable.h +++ b/src/core/lib/promise/observable.h @@ -28,6 +28,7 @@ #include "absl/types/optional.h" #include "absl/types/variant.h" +#include "src/core/lib/gprpp/sync.h" #include "src/core/lib/promise/activity.h" #include "src/core/lib/promise/detail/promise_like.h" #include "src/core/lib/promise/poll.h" diff --git a/src/core/lib/promise/pipe.h b/src/core/lib/promise/pipe.h index c2de5da4161..59baebb71d9 100644 --- a/src/core/lib/promise/pipe.h +++ b/src/core/lib/promise/pipe.h @@ -34,6 +34,7 @@ #include #include "src/core/lib/promise/activity.h" +#include "src/core/lib/promise/context.h" #include "src/core/lib/promise/detail/promise_factory.h" #include "src/core/lib/promise/intra_activity_waiter.h" #include "src/core/lib/promise/poll.h" diff --git a/src/core/lib/promise/sleep.cc b/src/core/lib/promise/sleep.cc index c28f2df04e3..a51b61797b0 100644 --- a/src/core/lib/promise/sleep.cc +++ b/src/core/lib/promise/sleep.cc @@ -16,6 +16,8 @@ #include "src/core/lib/promise/sleep.h" +#include "src/core/lib/iomgr/exec_ctx.h" + namespace grpc_core { Sleep::Sleep(Timestamp deadline) : state_(new State(deadline)) { diff --git a/src/core/lib/promise/sleep.h b/src/core/lib/promise/sleep.h index 0af4915c8c8..e67f1b50edd 100644 --- a/src/core/lib/promise/sleep.h +++ b/src/core/lib/promise/sleep.h @@ -17,6 +17,16 @@ #include +#include + +#include "absl/base/thread_annotations.h" +#include "absl/status/status.h" + +#include "src/core/lib/gprpp/ref_counted.h" +#include "src/core/lib/gprpp/sync.h" +#include "src/core/lib/gprpp/time.h" +#include "src/core/lib/iomgr/closure.h" +#include "src/core/lib/iomgr/error.h" #include "src/core/lib/iomgr/timer.h" #include "src/core/lib/promise/activity.h" #include "src/core/lib/promise/poll.h" diff --git a/src/core/lib/promise/try_seq.h b/src/core/lib/promise/try_seq.h index 65520f07daf..5486461a925 100644 --- a/src/core/lib/promise/try_seq.h +++ b/src/core/lib/promise/try_seq.h @@ -18,8 +18,10 @@ #include #include +#include #include +#include "absl/meta/type_traits.h" #include "absl/status/status.h" #include "absl/status/statusor.h" #include "absl/types/variant.h" diff --git a/src/core/lib/promise/wait_set.h b/src/core/lib/promise/wait_set.h index 79a0e0f2ea0..26aa39961cf 100644 --- a/src/core/lib/promise/wait_set.h +++ b/src/core/lib/promise/wait_set.h @@ -20,6 +20,7 @@ #include #include "absl/container/flat_hash_set.h" +#include "absl/hash/hash.h" #include "src/core/lib/promise/activity.h" #include "src/core/lib/promise/poll.h" diff --git a/tools/dockerfile/grpc_iwyu/iwyu.sh b/tools/dockerfile/grpc_iwyu/iwyu.sh index 0278035b378..adb716f581a 100755 --- a/tools/dockerfile/grpc_iwyu/iwyu.sh +++ b/tools/dockerfile/grpc_iwyu/iwyu.sh @@ -29,7 +29,7 @@ cat compile_commands.json | jq -r '.[].file' \ | tee iwyu_files.txt # run iwyu, filtering out changes to port_platform.h -xargs -a iwyu_files.txt /iwyu/iwyu_tool.py -p compile_commands_for_iwyu.json -j 16 \ +xargs -a iwyu_files.txt -I FILES /iwyu/iwyu_tool.py -p compile_commands_for_iwyu.json -j 16 FILES -- -Xiwyu --no_fwd_decls \ | grep -v -E "port_platform.h" \ | tee iwyu.out