[iwyu] Enable --no_fwd_decls on iwyu script (#29527)

* Flag flip

* Fixups

src/core/lib/promise/activity.cc

@@ -16,7 +16,7 @@
 
 #include "src/core/lib/promise/activity.h"
 
-#include "absl/base/attributes.h"
+#include <stddef.h>
 
 #include "src/core/lib/gprpp/atomic_utils.h"
 

src/core/lib/promise/arena_promise.h

@@ -17,8 +17,16 @@
 
 #include <grpc/support/port_platform.h>
 
+#include <stdlib.h>
+
+#include <type_traits>
+#include <utility>
+
+#include "absl/meta/type_traits.h"
+
 #include <grpc/support/log.h>
 
+#include "src/core/lib/promise/context.h"
 #include "src/core/lib/promise/poll.h"
 #include "src/core/lib/resource_quota/arena.h"
 

src/core/lib/promise/call_push_pull.h

@@ -19,6 +19,10 @@
 
 #include <assert.h>
 
+#include <type_traits>
+
+#include "absl/types/variant.h"
+
 #include "src/core/lib/gprpp/bitset.h"
 #include "src/core/lib/gprpp/construct_destruct.h"
 #include "src/core/lib/promise/detail/promise_like.h"

src/core/lib/promise/detail/basic_seq.h

@@ -21,6 +21,7 @@
 #include <cassert>
 #include <new>
 #include <tuple>
+#include <type_traits>
 #include <utility>
 
 #include "absl/meta/type_traits.h"
@@ -29,6 +30,7 @@
 
 #include "src/core/lib/gprpp/construct_destruct.h"
 #include "src/core/lib/promise/detail/promise_factory.h"
+#include "src/core/lib/promise/detail/promise_like.h"
 #include "src/core/lib/promise/detail/switch.h"
 #include "src/core/lib/promise/poll.h"
 

src/core/lib/promise/loop.h

@@ -20,6 +20,7 @@
 #include <new>
 #include <type_traits>
 
+#include "absl/status/status.h"
 #include "absl/status/statusor.h"
 #include "absl/types/variant.h"
 

src/core/lib/promise/observable.h

@@ -28,6 +28,7 @@
 #include "absl/types/optional.h"
 #include "absl/types/variant.h"
 
+#include "src/core/lib/gprpp/sync.h"
 #include "src/core/lib/promise/activity.h"
 #include "src/core/lib/promise/detail/promise_like.h"
 #include "src/core/lib/promise/poll.h"

src/core/lib/promise/pipe.h

@@ -34,6 +34,7 @@
 #include <grpc/support/log.h>
 
 #include "src/core/lib/promise/activity.h"
+#include "src/core/lib/promise/context.h"
 #include "src/core/lib/promise/detail/promise_factory.h"
 #include "src/core/lib/promise/intra_activity_waiter.h"
 #include "src/core/lib/promise/poll.h"

src/core/lib/promise/sleep.cc

@@ -16,6 +16,8 @@
 
 #include "src/core/lib/promise/sleep.h"
 
+#include "src/core/lib/iomgr/exec_ctx.h"
+
 namespace grpc_core {
 
 Sleep::Sleep(Timestamp deadline) : state_(new State(deadline)) {

src/core/lib/promise/sleep.h

@@ -17,6 +17,16 @@
 
 #include <grpc/support/port_platform.h>
 
+#include <utility>
+
+#include "absl/base/thread_annotations.h"
+#include "absl/status/status.h"
+
+#include "src/core/lib/gprpp/ref_counted.h"
+#include "src/core/lib/gprpp/sync.h"
+#include "src/core/lib/gprpp/time.h"
+#include "src/core/lib/iomgr/closure.h"
+#include "src/core/lib/iomgr/error.h"
 #include "src/core/lib/iomgr/timer.h"
 #include "src/core/lib/promise/activity.h"
 #include "src/core/lib/promise/poll.h"

src/core/lib/promise/try_seq.h

@@ -18,8 +18,10 @@
 #include <grpc/support/port_platform.h>
 
 #include <tuple>
+#include <type_traits>
 #include <utility>
 
+#include "absl/meta/type_traits.h"
 #include "absl/status/status.h"
 #include "absl/status/statusor.h"
 #include "absl/types/variant.h"

src/core/lib/promise/wait_set.h

@@ -20,6 +20,7 @@
 #include <utility>
 
 #include "absl/container/flat_hash_set.h"
+#include "absl/hash/hash.h"
 
 #include "src/core/lib/promise/activity.h"
 #include "src/core/lib/promise/poll.h"

tools/dockerfile/grpc_iwyu/iwyu.sh

@@ -29,7 +29,7 @@ cat compile_commands.json | jq -r '.[].file' \
   | tee iwyu_files.txt
 
 # run iwyu, filtering out changes to port_platform.h
-xargs -a iwyu_files.txt /iwyu/iwyu_tool.py -p compile_commands_for_iwyu.json -j 16 \
+xargs -a iwyu_files.txt -I FILES /iwyu/iwyu_tool.py -p compile_commands_for_iwyu.json -j 16 FILES -- -Xiwyu --no_fwd_decls \
   | grep -v -E "port_platform.h" \
   | tee iwyu.out