From a5b517fa155d323b52f10d0664acb5d0022399ab Mon Sep 17 00:00:00 2001 From: Craig Tiller Date: Thu, 28 May 2015 13:22:34 -0700 Subject: [PATCH 1/3] Factor out extra json generation This logic needs to be reusable in some other scripts --- tools/buildgen/generate_build_additions.sh | 8 ++++++++ tools/buildgen/generate_projects.sh | 9 +-------- 2 files changed, 9 insertions(+), 8 deletions(-) create mode 100644 tools/buildgen/generate_build_additions.sh diff --git a/tools/buildgen/generate_build_additions.sh b/tools/buildgen/generate_build_additions.sh new file mode 100644 index 00000000000..65a7af3c4e9 --- /dev/null +++ b/tools/buildgen/generate_build_additions.sh @@ -0,0 +1,8 @@ +gen_build_json_dirs="test/core/end2end test/core/bad_client" +gen_build_files="" +for gen_build_json in $gen_build_json_dirs +do + output_file=`mktemp /tmp/genXXXXXX` + $gen_build_json/gen_build_json.py > $output_file + gen_build_files="$gen_build_files $output_file" +done diff --git a/tools/buildgen/generate_projects.sh b/tools/buildgen/generate_projects.sh index d896380c374..8aba118f370 100755 --- a/tools/buildgen/generate_projects.sh +++ b/tools/buildgen/generate_projects.sh @@ -38,19 +38,12 @@ fi cd `dirname $0`/../.. mako_renderer=tools/buildgen/mako_renderer.py -gen_build_json_dirs="test/core/end2end test/core/bad_client" if [ "x$TEST" != "x" ] ; then tools/buildgen/build-cleaner.py build.json fi -gen_build_files="" -for gen_build_json in $gen_build_json_dirs -do - output_file=`mktemp /tmp/genXXXXXX` - $gen_build_json/gen_build_json.py > $output_file - gen_build_files="$gen_build_files $output_file" -done +source tools/buildgen/generate_build_additions.sh global_plugins=`find ./tools/buildgen/plugins -name '*.py' | sort | grep -v __init__ | awk ' { printf "-p %s ", $0 } '` From b8933b3878daf79b845e44fe962d6997891178a7 Mon Sep 17 00:00:00 2001 From: Craig Tiller Date: Thu, 28 May 2015 13:23:46 -0700 Subject: [PATCH 2/3] Add copyrights --- tools/buildgen/generate_build_additions.sh | 30 ++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/tools/buildgen/generate_build_additions.sh b/tools/buildgen/generate_build_additions.sh index 65a7af3c4e9..44fc2558fa5 100644 --- a/tools/buildgen/generate_build_additions.sh +++ b/tools/buildgen/generate_build_additions.sh @@ -1,3 +1,33 @@ +#!/bin/sh +# Copyright 2015, Google Inc. +# All rights reserved. +# +# Redistribution and use in source and binary forms, with or without +# modification, are permitted provided that the following conditions are +# met: +# +# * Redistributions of source code must retain the above copyright +# notice, this list of conditions and the following disclaimer. +# * Redistributions in binary form must reproduce the above +# copyright notice, this list of conditions and the following disclaimer +# in the documentation and/or other materials provided with the +# distribution. +# * Neither the name of Google Inc. nor the names of its +# contributors may be used to endorse or promote products derived from +# this software without specific prior written permission. +# +# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS +# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT +# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR +# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT +# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, +# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT +# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, +# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY +# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT +# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE +# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + gen_build_json_dirs="test/core/end2end test/core/bad_client" gen_build_files="" for gen_build_json in $gen_build_json_dirs From 06e3f446ee034ab50e117396fc87e40ab4aa111f Mon Sep 17 00:00:00 2001 From: Craig Tiller Date: Thu, 28 May 2015 14:01:26 -0700 Subject: [PATCH 3/3] Eliminate bashisms --- tools/buildgen/generate_projects.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/buildgen/generate_projects.sh b/tools/buildgen/generate_projects.sh index 8aba118f370..53998677465 100755 --- a/tools/buildgen/generate_projects.sh +++ b/tools/buildgen/generate_projects.sh @@ -43,7 +43,7 @@ if [ "x$TEST" != "x" ] ; then tools/buildgen/build-cleaner.py build.json fi -source tools/buildgen/generate_build_additions.sh +. tools/buildgen/generate_build_additions.sh global_plugins=`find ./tools/buildgen/plugins -name '*.py' | sort | grep -v __init__ | awk ' { printf "-p %s ", $0 } '`