Add a TODO to enable microbenmarking for performance testing

pull/10079/head
Matt Kwong 8 years ago
parent 063adf3fb4
commit 504adae372
  1. 4
      tools/jenkins/run_performance.sh
  2. 3
      tools/run_tests/run_microbenchmark.py

@ -37,6 +37,6 @@ BENCHMARKS_TO_RUN="bm_closure bm_cq bm_call_create bm_error bm_chttp2_hpack bm_c
# Enter the gRPC repo root
cd $(dirname $0)/../..
# tools/run_tests/run_performance_tests.py -l c++ node ruby csharp python --netperf --category smoketest
tools/run_tests/run_performance_tests.py -l c++ node ruby csharp python --netperf --category smoketest
# todo(mattkwong): Change performance test to use microbenchmarking
tools/run_tests/run_microbenchmark.py -c summary --diff_perf origin/$ghprbTargetBranch -b $BENCHMARKS_TO_RUN
# tools/run_tests/run_microbenchmark.py -c summary --diff_perf origin/$ghprbTargetBranch -b $BENCHMARKS_TO_RUN

@ -245,8 +245,7 @@ try:
run_summary(bm_name, 'opt', bm_name)
run_summary(bm_name, 'counters', bm_name)
where_am_i = subprocess.check_output(['git', 'rev-parse', '--abbrev-ref', 'HEAD']).strip()
# todo(mattkwong): uncomment this before merging
# subprocess.check_call(['git', 'checkout', args.diff_perf])
subprocess.check_call(['git', 'checkout', args.diff_perf])
comparables = []
subprocess.check_call(['make', 'clean'])
try:

Loading…
Cancel
Save