addressed feedback.

pull/6826/head
Makarand Dharmapurikar 9 years ago
parent 6f9501098e
commit 4f11ab1ffd
  1. 2
      src/compiler/objective_c_generator.cc
  2. 2
      src/objective-c/ProtoRPC/ProtoMethod.h
  3. 6
      src/objective-c/ProtoRPC/ProtoRPC.h
  4. 2
      src/objective-c/ProtoRPC/ProtoRPC.m
  5. 4
      src/objective-c/ProtoRPC/ProtoService.h

@ -94,7 +94,7 @@ void PrintSimpleSignature(Printer *printer, const MethodDescriptor *method,
void PrintAdvancedSignature(Printer *printer, const MethodDescriptor *method,
map< ::grpc::string, ::grpc::string> vars) {
vars["method_name"] = "RPCTo" + vars["method_name"];
vars["return_type"] = "GRPCProtoRPC *";
vars["return_type"] = "GRPCProtoCall *";
PrintMethodSignature(printer, method, vars);
}

@ -51,7 +51,7 @@ __attribute__((deprecated("Please use GRPCProtoMethod.")))
@end
/**
* This subclass is empty now. Eventually we'll remove ProtoService class
* This subclass is empty now. Eventually we'll remove ProtoMethod class
* to avoid potential naming conflict
*/
@interface GRPCProtoMethod : ProtoMethod

@ -36,7 +36,7 @@
#import "ProtoMethod.h"
__attribute__((deprecated("Please use GRPCProtoRPC.")))
__attribute__((deprecated("Please use GRPCProtoCall.")))
@interface ProtoRPC : GRPCCall
- (instancetype)initWithHost:(NSString *)host
@ -49,9 +49,9 @@ __attribute__((deprecated("Please use GRPCProtoRPC.")))
@end
/**
* This subclass is empty now. Eventually we'll remove ProtoService class
* This subclass is empty now. Eventually we'll remove ProtoRPC class
* to avoid potential naming conflict
*/
@interface GRPCProtoRPC : ProtoRPC
@interface GRPCProtoCall : ProtoRPC
@end

@ -118,6 +118,6 @@ static NSError *ErrorForBadProto(id proto, Class expectedClass, NSError *parsing
}
@end
@implementation GRPCProtoRPC
@implementation GRPCProtoCall
@end

@ -33,7 +33,7 @@
#import <Foundation/Foundation.h>
@class GRPCProtoRPC;
@class GRPCProtoCall;
@protocol GRXWriteable;
@class GRXWriter;
@ -44,7 +44,7 @@ __attribute__((deprecated("Please use GRPCProtoService.")))
packageName:(NSString *)packageName
serviceName:(NSString *)serviceName NS_DESIGNATED_INITIALIZER;
- (GRPCProtoRPC *)RPCToMethod:(NSString *)method
- (GRPCProtoCall *)RPCToMethod:(NSString *)method
requestsWriter:(GRXWriter *)requestsWriter
responseClass:(Class)responseClass
responsesWriteable:(id<GRXWriteable>)responsesWriteable;

Loading…
Cancel
Save