Make strong reference in notification center callback

6 years ago · 4e294d2aa3
parent 5c275b5f22
commit 4e294d2aa3
1 changed files with 9 additions and 6 deletions
--- a/src/objective-c/GRPCClient/GRPCCall.m
+++ b/src/objective-c/GRPCClient/GRPCCall.m
@ -531,12 +531,15 @@ static NSString *const kBearerPrefix = @"Bearer ";

 - (void)connectivityChanged:(NSNotification *)note {
  // Cancel underlying call upon this notification
-  [self cancelCall];
-  [self maybeFinishWithError:[NSError errorWithDomain:kGRPCErrorDomain
-                                                 code:GRPCErrorCodeUnavailable
-                                             userInfo:@{
-                                               NSLocalizedDescriptionKey : @"Connectivity lost."
-                                             }]];
+  __strong GRPCCall *strongSelf = self;
+  if (strongSelf) {
+    [self cancelCall];
+    [self maybeFinishWithError:[NSError errorWithDomain:kGRPCErrorDomain
+                                                   code:GRPCErrorCodeUnavailable
+                                               userInfo:@{
+                                                 NSLocalizedDescriptionKey : @"Connectivity lost."
+                                               }]];
+  }
 }

@end