[experiments] Fix experiment expiry and avoid failing BUILDS on expired experiments. (#33325)

pull/33327/head
Vignesh Babu 2 years ago committed by GitHub
parent 0c6902e32e
commit 4adf95ca9e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 6
      src/core/lib/experiments/experiments.yaml
  2. 6
      tools/codegen/core/experiments_compiler.py

@ -39,12 +39,12 @@
TCP would not indicate completion of a read operation until a specified
number of bytes have been read over the socket.
Buffers are also allocated according to estimated RPC sizes.
expiry: 2023/06/01
expiry: 2023/08/01
owner: vigneshbabu@google.com
test_tags: ["endpoint_test", "flow_control_test"]
- name: tcp_rcv_lowat
description: Use SO_RCVLOWAT to avoid wakeups on the read path.
expiry: 2023/06/01
expiry: 2023/08/01
owner: vigneshbabu@google.com
test_tags: ["endpoint_test", "flow_control_test"]
- name: peer_state_based_framing
@ -52,7 +52,7 @@
If set, the max sizes of frames sent to lower layers is controlled based
on the peer's memory pressure which is reflected in its max http2 frame
size.
expiry: 2023/06/01
expiry: 2023/08/01
owner: vigneshbabu@google.com
test_tags: ["flow_control_test"]
- name: memory_pressure_controller

@ -160,14 +160,12 @@ class ExperimentDefinition(object):
two_quarters_from_now = today + datetime.timedelta(days=180)
expiry = datetime.datetime.strptime(self._expiry, '%Y/%m/%d').date()
if expiry < today:
print("ERROR: experiment %s expired on %s" %
print("WARNING: experiment %s expired on %s" %
(self._name, self._expiry))
self._error = True
if expiry > two_quarters_from_now:
print("ERROR: experiment %s expires far in the future on %s" %
print("WARNING: experiment %s expires far in the future on %s" %
(self._name, self._expiry))
print("expiry should be no more than two quarters from now")
self._error = True
return not self._error
def AddRolloutSpecification(self, allowed_defaults, rollout_attributes):

Loading…
Cancel
Save