Merge pull request #20657 from vjpai/remove_warn_4

Remove unused parameter warnings (4 of 20)
reviewable/pr18856/r15^2
Vijay Pai 5 years ago committed by GitHub
commit 4750715569
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 2
      test/core/client_channel/resolvers/fake_resolver_test.cc
  2. 2
      test/core/client_channel/resolvers/sockaddr_resolver_test.cc
  3. 4
      test/core/client_channel/service_config_test.cc
  4. 2
      test/core/compression/compression_test.cc
  5. 2
      test/core/compression/stream_compression_test.cc
  6. 6
      test/core/end2end/bad_server_response_test.cc
  7. 2
      test/core/end2end/dualstack_socket_test.cc
  8. 2
      test/core/end2end/fixtures/h2_census.cc
  9. 2
      test/core/end2end/fixtures/h2_compress.cc
  10. 7
      test/core/end2end/fixtures/h2_fakesec.cc

@ -55,7 +55,7 @@ class ResultHandler : public grpc_core::Resolver::ResultHandler {
ev_ = nullptr;
}
void ReturnError(grpc_error* error) override {}
void ReturnError(grpc_error* /*error*/) override {}
private:
grpc_core::Resolver::Result expected_;

@ -32,7 +32,7 @@ static grpc_combiner* g_combiner;
class ResultHandler : public grpc_core::Resolver::ResultHandler {
public:
void ReturnResult(grpc_core::Resolver::Result result) override {}
void ReturnResult(grpc_core::Resolver::Result /*result*/) override {}
void ReturnError(grpc_error* error) override { GRPC_ERROR_UNREF(error); }
};

@ -116,14 +116,14 @@ class TestParser2 : public ServiceConfig::Parser {
class ErrorParser : public ServiceConfig::Parser {
public:
UniquePtr<ServiceConfig::ParsedConfig> ParsePerMethodParams(
const grpc_json* json, grpc_error** error) override {
const grpc_json* /*json*/, grpc_error** error) override {
GPR_DEBUG_ASSERT(error != nullptr);
*error = GRPC_ERROR_CREATE_FROM_STATIC_STRING(MethodError());
return nullptr;
}
UniquePtr<ServiceConfig::ParsedConfig> ParseGlobalParams(
const grpc_json* json, grpc_error** error) override {
const grpc_json* /*json*/, grpc_error** error) override {
GPR_DEBUG_ASSERT(error != nullptr);
*error = GRPC_ERROR_CREATE_FROM_STATIC_STRING(GlobalError());
return nullptr;

@ -335,7 +335,7 @@ static void test_channel_args_compression_algorithm_states(void) {
grpc_channel_args_destroy(ch_args);
}
int main(int argc, char** argv) {
int main(int /*argc*/, char** /*argv*/) {
grpc_init();
test_compression_algorithm_parse();
test_compression_algorithm_name();

@ -287,7 +287,7 @@ static void test_stream_compression_sync_flush() {
grpc_slice_buffer_destroy(&sink);
}
int main(int argc, char** argv) {
int main(int /*argc*/, char** /*argv*/) {
grpc_init();
test_stream_compression_simple_compress_decompress();
test_stream_compression_simple_compress_decompress_with_output_size_constraint();

@ -92,7 +92,7 @@ static grpc_closure on_write;
static void* tag(intptr_t t) { return (void*)t; }
static void done_write(void* arg, grpc_error* error) {
static void done_write(void* /*arg*/, grpc_error* error) {
GPR_ASSERT(error == GRPC_ERROR_NONE);
gpr_atm_rel_store(&state.done_atm, 1);
@ -107,7 +107,7 @@ static void handle_write() {
grpc_endpoint_write(state.tcp, &state.outgoing_buffer, &on_write, nullptr);
}
static void handle_read(void* arg, grpc_error* error) {
static void handle_read(void* /*arg*/, grpc_error* error) {
GPR_ASSERT(error == GRPC_ERROR_NONE);
state.incoming_data_length += state.temp_incoming_buffer.length;
@ -132,7 +132,7 @@ static void handle_read(void* arg, grpc_error* error) {
}
static void on_connect(void* arg, grpc_endpoint* tcp,
grpc_pollset* accepting_pollset,
grpc_pollset* /*accepting_pollset*/,
grpc_tcp_server_acceptor* acceptor) {
gpr_free(acceptor);
test_tcp_server* server = static_cast<test_tcp_server*>(arg);

@ -51,7 +51,7 @@ static void drain_cq(grpc_completion_queue* cq) {
} while (ev.type != GRPC_QUEUE_SHUTDOWN);
}
static void do_nothing(void* ignored) {}
static void do_nothing(void* /*ignored*/) {}
static void log_resolved_addrs(const char* label, const char* hostname) {
grpc_resolved_addresses* res = nullptr;

@ -40,7 +40,7 @@ struct fullstack_fixture_data {
};
static grpc_end2end_test_fixture chttp2_create_fixture_fullstack(
grpc_channel_args* client_args, grpc_channel_args* server_args) {
grpc_channel_args* /*client_args*/, grpc_channel_args* /*server_args*/) {
grpc_end2end_test_fixture f;
int port = grpc_pick_unused_port_or_die();
fullstack_fixture_data* ffd = grpc_core::New<fullstack_fixture_data>();

@ -47,7 +47,7 @@ struct fullstack_compression_fixture_data {
};
static grpc_end2end_test_fixture chttp2_create_fixture_fullstack_compression(
grpc_channel_args* client_args, grpc_channel_args* server_args) {
grpc_channel_args* /*client_args*/, grpc_channel_args* /*server_args*/) {
grpc_end2end_test_fixture f;
int port = grpc_pick_unused_port_or_die();
fullstack_compression_fixture_data* ffd =

@ -36,7 +36,7 @@ struct fullstack_secure_fixture_data {
};
static grpc_end2end_test_fixture chttp2_create_fixture_secure_fullstack(
grpc_channel_args* client_args, grpc_channel_args* server_args) {
grpc_channel_args* /*client_args*/, grpc_channel_args* /*server_args*/) {
grpc_end2end_test_fixture f;
int port = grpc_pick_unused_port_or_die();
fullstack_secure_fixture_data* ffd =
@ -51,8 +51,9 @@ static grpc_end2end_test_fixture chttp2_create_fixture_secure_fullstack(
return f;
}
static void process_auth_failure(void* state, grpc_auth_context* ctx,
const grpc_metadata* md, size_t md_count,
static void process_auth_failure(void* state, grpc_auth_context* /*ctx*/,
const grpc_metadata* /*md*/,
size_t /*md_count*/,
grpc_process_auth_metadata_done_cb cb,
void* user_data) {
GPR_ASSERT(state == nullptr);

Loading…
Cancel
Save