diff --git a/src/node/ext/call.cc b/src/node/ext/call.cc index 560869e6fa4..49b306202bd 100644 --- a/src/node/ext/call.cc +++ b/src/node/ext/call.cc @@ -172,6 +172,9 @@ Handle Op::GetOpType() const { return NanEscapeScope(NanNew(GetTypeString())); } +Op::~Op() { +} + class SendMetadataOp : public Op { public: Handle GetNodeValue() const { @@ -325,7 +328,7 @@ class ReadMessageOp : public Op { } ~ReadMessageOp() { if (recv_message != NULL) { - gpr_free(recv_message); + grpc_byte_buffer_destroy(recv_message); } } Handle GetNodeValue() const { diff --git a/src/node/ext/call.h b/src/node/ext/call.h index 89f81dcf4dc..a01f03489e7 100644 --- a/src/node/ext/call.h +++ b/src/node/ext/call.h @@ -88,6 +88,7 @@ struct Resources { class Op { public: + virtual ~Op(); virtual v8::Handle GetNodeValue() const = 0; virtual bool ParseOp(v8::Handle value, grpc_op *out, shared_ptr resources) = 0; @@ -98,7 +99,6 @@ class Op { }; typedef std::vector> OpVec; - struct tag { tag(NanCallback *callback, OpVec *ops, shared_ptr resources);