[Documentation][Gpr_To_Absl_Logging] Fix GRPC_VERBOSITY docs (#37011)

[Documentation][Gpr_To_Absl_Logging] Fix GRPC_VERBOSITY docs

Closes #37011

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/37011 from tanvi-jagtap:fix_docs 18bf235baf
PiperOrigin-RevId: 646315660

TROUBLESHOOTING.md

@@ -7,44 +7,47 @@ This guide is for troubleshooting gRPC implementations based on C core library (
 Extra logging can be very useful for diagnosing problems. It can be used to increase the amount of information
 that gets printed to stderr.
 
-## GRPC_VERBOSITY
+## Setting Logging Severity and Verbosity
 
-<!-- BEGIN_GOOGLE_INTERNAL_DOCUMENTATION
+[gRPC uses absl logging](https://abseil.io/docs/cpp/guides/logging).
-GRPC_VERBOSITY has been disabled for internal usage and will not work anymore.
+Verbosity can be set using absl flags such as
-If anyone wants to debug, we need to set verbose logs using absl.
+`--minloglevel`, `--v` and `--vmodule`.
-END_GOOGLE_INTERNAL_DOCUMENTATION -->
 
-<!-- BEGIN_OPEN_SOURCE_DOCUMENTATION -->
+These can also be programmatically set using
-`GRPC_VERBOSITY` is used to set the minimum level of log messages printed by gRPC (supported values are `DEBUG`, `INFO` and `ERROR`). If this environment variable is unset, only `ERROR` logs will be printed. `ERROR` is recomeded for production systems.
+[these absl APIs.](https://github.com/abseil/abseil-cpp/blob/master/absl/log/globals.h)
-<!-- END_OPEN_SOURCE_DOCUMENTATION -->
 
-## GRPC_TRACE
+Example
+```
+# Disable all logs other than FATAL for the entire application
+./helloworld_application_using_grpc --v=-1 --minloglevel=3
+```
+
+## GRPC_VERBOSITY (DEPRECATED)
 
-<!-- BEGIN_GOOGLE_INTERNAL_DOCUMENTATION
+[Environment Variables Overview](doc/environment_variables.md)
-GRPC_VERBOSITY has been disabled for internal usage and will not work anymore.
-If anyone wants to debug, we need to set verbose logs using absl.
-END_GOOGLE_INTERNAL_DOCUMENTATION -->
 
-`GRPC_TRACE` can be used to enable extra logging for some internal gRPC components. Enabling the right traces can be invaluable
+## GRPC_TRACE
-for diagnosing for what is going wrong when things aren't working as intended. Possible values for `GRPC_TRACE` are listed in [Environment Variables Overview](doc/environment_variables.md).
+
+`GRPC_TRACE` can be used to enable extra logging for specific internal gRPC components. Enabling the right traces can be invaluable
+for diagnosing for what is going wrong when things aren't working as intended. Possible values for `GRPC_TRACE` are [listed here](doc/trace_flags.md).
 Multiple traces can be enabled at once (use comma as separator).
 
 ```
-# Enable debug logs for an application
+# Enable debug logs for the entire application
-GRPC_VERBOSITY=debug ./helloworld_application_using_grpc
+./helloworld_application_using_grpc --v=2 --minloglevel=0
 ```
 
 ```
 # Print information about invocations of low-level C core API.
-# Note that trace logs of log level DEBUG won't be displayed.
+# Note that trace logs that use `VLOG` won't be displayed.
-# Also note that most tracers user log level INFO, so without setting
+# Many tracers user log level INFO.
-# GPRC_VERBOSITY accordingly, no traces will be printed.
+# So unless absl settings are correct, no traces will be printed.
-GRPC_VERBOSITY=info GRPC_TRACE=api ./helloworld_application_using_grpc
+GRPC_TRACE=api ./helloworld_application_using_grpc --v=-1 --minloglevel=0
 ```
 
 ```
-# Print info from 3 different tracers, including tracing logs with log level DEBUG
+# Print info from 3 different tracers, including tracing logs
-GRPC_VERBOSITY=debug GRPC_TRACE=tcp,http,api ./helloworld_application_using_grpc
+GRPC_TRACE=tcp,http,api ./helloworld_application_using_grpc  --v=2 --minloglevel=0
 ```
 
 Known limitations: `GPRC_TRACE=tcp` is currently not implemented for Windows (you won't see any tcp traces).
@@ -52,3 +55,11 @@ Known limitations: `GPRC_TRACE=tcp` is currently not implemented for Windows (yo
 Please note that the `GRPC_TRACE` environment variable has nothing to do with gRPC's "tracing" feature (= tracing RPCs in
 microservice environment to gain insight about how requests are processed by deployment), it is merely used to enable printing
 of extra logs.
+
+## Preventing gRPC Log Noise
+
+Log noise could consume a lot of resources. We recommend tuning settings for production systems very carefully.
+*	Avoid using GRPC_VERBOSITY flag. This has been deprecated. If this value of this flag is anything other than "ERROR" or "NONE" it will cause log noise.
+*	Always avoid setting --v and --vmodule to anything other than -1 for production systems.
+*	Avoid setting --minloglevel=0 for production systems. Anyting greater than 0 should be fine.
+*   If setting this does not eliminate your log noise, look for instances of functions `--v`, `--vmodule`, `absl::SetVLogLevel` and `absl::SetMinLogLevel` in your entire codebase and any libraries/components/configs that you may be using.

doc/environment_variables.md

@@ -46,14 +46,13 @@ some configuration as environment variables that can be set.
   Available tracers and their usage can be found in
   [gRPC Trace Flags](trace_flags.md)
 
-* GRPC_VERBOSITY
+* GRPC_VERBOSITY (DEPRECATED)
-<!-- BEGIN_GOOGLE_INTERNAL_DOCUMENTATION"
-GRPC_VERBOSITY has been disabled for internal usage and will not work anymore.
-If anyone wants to debug, we need to set verbose logs using absl.
-END_GOOGLE_INTERNAL_DOCUMENTATION -->
 
 <!-- BEGIN_OPEN_SOURCE_DOCUMENTATION -->
-`GRPC_VERBOSITY` is used to set the minimum level of log messages printed by gRPC (supported values are `DEBUG`, `INFO` and `ERROR`). If this environment variable is unset, only `ERROR` logs will be printed.
+  `GRPC_VERBOSITY` is used to set the minimum level of log messages printed. Supported values are `DEBUG`, `INFO`, `ERROR` and `NONE`.
+
+  We only support this flag for legacy reasons. If this environment variable is set, then gRPC will set absl MinLogValue and absl SetVLogLevel. This will alter the log settings of the entire application, not just gRPC code. For that reason, it is not recommended. Our recommendation is to avoid using this flag and [set log verbosity using absl](https://abseil.io/docs/cpp/guides/logging).
+
   gRPC logging verbosity - one of:
   - DEBUG - log INFO, WARNING, ERROR and FATAL messages. Also sets absl VLOG(2) logs enabled. This is not recommended for production systems. This will be expensive for staging environments too, so it can be used when you want to debug a specific issue. 
   - INFO - log INFO, WARNING, ERROR and FATAL messages. This is not recommended for production systems. This may be slightly expensive for staging environments too. We recommend that you use your discretion for staging environments.
@@ -65,9 +64,8 @@ END_GOOGLE_INTERNAL_DOCUMENTATION -->
   - If nothing is set by the external application also, the default set by absl will be honoured.
 <!-- END_OPEN_SOURCE_DOCUMENTATION -->
 
-* GRPC_STACKTRACE_MINLOGLEVEL
+* GRPC_STACKTRACE_MINLOGLEVEL (DEPRECATED)
-  Minimum loglevel to print the stack-trace - one of DEBUG, INFO, ERROR, and NONE.
+  This will not work anymore.
-  NONE is a default value.
 
 * GRPC_TRACE_FUZZER
   if set, the fuzzers will output trace (it is usually suppressed).