From 40ee9084e9216019c48a48eaf8bdf2dc8127ec48 Mon Sep 17 00:00:00 2001 From: Xuan Wang Date: Wed, 31 May 2023 12:58:52 -0700 Subject: [PATCH] [PSM interop] Don't fail target if sub-target already failed (#33222) We configured TestGrid to file bug separately for each failed sub-target, if we still fail the main target, TestGrid will fail duplicate bugs. --- tools/internal_ci/linux/grpc_xds_k8s_lb.sh | 3 --- tools/internal_ci/linux/grpc_xds_k8s_lb_python.sh | 3 --- tools/internal_ci/linux/grpc_xds_k8s_xlang.sh | 3 --- tools/internal_ci/linux/psm-security-python.sh | 3 --- tools/internal_ci/linux/psm-security.sh | 3 --- 5 files changed, 15 deletions(-) diff --git a/tools/internal_ci/linux/grpc_xds_k8s_lb.sh b/tools/internal_ci/linux/grpc_xds_k8s_lb.sh index f0c1c43918c..7053bdfe15f 100755 --- a/tools/internal_ci/linux/grpc_xds_k8s_lb.sh +++ b/tools/internal_ci/linux/grpc_xds_k8s_lb.sh @@ -174,9 +174,6 @@ main() { run_test $test || (( ++failed_tests )) done echo "Failed test suites: ${failed_tests}" - if (( failed_tests > 0 )); then - exit 1 - fi } main "$@" diff --git a/tools/internal_ci/linux/grpc_xds_k8s_lb_python.sh b/tools/internal_ci/linux/grpc_xds_k8s_lb_python.sh index 4dd3e34f399..431449925f5 100755 --- a/tools/internal_ci/linux/grpc_xds_k8s_lb_python.sh +++ b/tools/internal_ci/linux/grpc_xds_k8s_lb_python.sh @@ -179,9 +179,6 @@ main() { run_test $test || (( ++failed_tests )) done echo "Failed test suites: ${failed_tests}" - if (( failed_tests > 0 )); then - exit 1 - fi } main "$@" diff --git a/tools/internal_ci/linux/grpc_xds_k8s_xlang.sh b/tools/internal_ci/linux/grpc_xds_k8s_xlang.sh index 4851e06616b..93922a06c27 100755 --- a/tools/internal_ci/linux/grpc_xds_k8s_xlang.sh +++ b/tools/internal_ci/linux/grpc_xds_k8s_xlang.sh @@ -96,9 +96,6 @@ main() { set +x echo "Failed test suites list: ${failed_string}" echo "Successful test suites list: ${successful_string}" - if (( failed_tests > 0 )); then - exit 1 - fi } main "$@" diff --git a/tools/internal_ci/linux/psm-security-python.sh b/tools/internal_ci/linux/psm-security-python.sh index 792f4415482..bda9ed8347e 100755 --- a/tools/internal_ci/linux/psm-security-python.sh +++ b/tools/internal_ci/linux/psm-security-python.sh @@ -179,9 +179,6 @@ main() { run_test $test || (( ++failed_tests )) done echo "Failed test suites: ${failed_tests}" - if (( failed_tests > 0 )); then - exit 1 - fi } main "$@" diff --git a/tools/internal_ci/linux/psm-security.sh b/tools/internal_ci/linux/psm-security.sh index cec4727c3b0..8c102d1b7ff 100755 --- a/tools/internal_ci/linux/psm-security.sh +++ b/tools/internal_ci/linux/psm-security.sh @@ -163,9 +163,6 @@ main() { run_test $test || (( ++failed_tests )) done echo "Failed test suites: ${failed_tests}" - if (( failed_tests > 0 )); then - exit 1 - fi } main "$@"