From 40b6123d1498468033ddcdbe324c38ec56e93e19 Mon Sep 17 00:00:00 2001 From: Yash Tibrewal Date: Wed, 8 May 2019 10:53:26 -0700 Subject: [PATCH] Fix TODOs --- src/core/ext/filters/client_channel/client_channel.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/core/ext/filters/client_channel/client_channel.cc b/src/core/ext/filters/client_channel/client_channel.cc index 99066e4e82c..787fe2f4750 100644 --- a/src/core/ext/filters/client_channel/client_channel.cc +++ b/src/core/ext/filters/client_channel/client_channel.cc @@ -1078,8 +1078,8 @@ ChannelData::ChannelData(grpc_channel_element_args* args, grpc_error** error) // Get default service config const char* service_config_json = grpc_channel_arg_get_string( grpc_channel_args_find(args->channel_args, GRPC_ARG_SERVICE_CONFIG)); - // Make sure we set the channel in TRANSIENT_FAILURE on an invalid default - // service config + // TODO(yashkt): Make sure we set the channel in TRANSIENT_FAILURE on an + // invalid default service config if (service_config_json != nullptr) { *error = GRPC_ERROR_NONE; default_service_config_ = ServiceConfig::Create(service_config_json, error); @@ -1175,7 +1175,7 @@ void ChannelData::ProcessLbPolicy( } // Special case: If at least one balancer address is present, we use // the grpclb policy, regardless of what the resolver has returned. - // TODO(yashkt) : Test that we do not use this special case if the we have set + // TODO(yashkt) : Test that we do not use this special case if we have set // the lb policy from the loadBalancingConfig field bool found_balancer_address = false; for (size_t i = 0; i < resolver_result.addresses.size(); ++i) {