Address reviewer comments

pull/14459/head
Vijay Pai 7 years ago committed by GitHub
parent 162ae4f50c
commit 4013f0ccda
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 3
      src/core/lib/gprpp/thd.h

@ -42,6 +42,7 @@ class ThreadInternalsInterface {
virtual void Join() GRPC_ABSTRACT; virtual void Join() GRPC_ABSTRACT;
GRPC_ABSTRACT_BASE_CLASS GRPC_ABSTRACT_BASE_CLASS
}; };
} // namespace internal } // namespace internal
class Thread { class Thread {
@ -98,9 +99,9 @@ class Thread {
GPR_ASSERT(state_ == FAILED); GPR_ASSERT(state_ == FAILED);
} }
}; };
void Join() { void Join() {
if (impl_ != nullptr) { if (impl_ != nullptr) {
GPR_ASSERT(state_ == STARTED);
impl_->Join(); impl_->Join();
grpc_core::Delete(impl_); grpc_core::Delete(impl_);
state_ = DONE; state_ = DONE;

Loading…
Cancel
Save