Add error checking for server args in PHP

7 years ago · 3f002567c4
parent 632b58cb82
commit 3f002567c4
1 changed files with 4 additions and 1 deletions
--- a/src/php/ext/grpc/server.c
+++ b/src/php/ext/grpc/server.c
@ -75,7 +75,10 @@ PHP_METHOD(Server, __construct) {
  if (args_array == NULL) {
    server->wrapped = grpc_server_create(NULL, NULL);
  } else {
-    php_grpc_read_args_array(args_array, &args TSRMLS_CC);
+    if (php_grpc_read_args_array(args_array, &args TSRMLS_CC) == FAILURE) {
+      efree(args.args);
+      return;
+    }
    server->wrapped = grpc_server_create(&args, NULL);
    efree(args.args);
  }