From 3e2acbd947994fbeb9ec4f4140ae228dd48495e8 Mon Sep 17 00:00:00 2001 From: Sergii Tkachenko Date: Fri, 21 Jul 2023 12:44:07 -0400 Subject: [PATCH] [PSM Interop] Legacy tests: fix xDS test client build (#33796) https://github.com/grpc/grpc/pull/33699 incorrectly changed the legacy builds to not just use the test driver from the master, but also to build from it. This PR fixes the issue, and also updates the python job to work use the driver from master. --- .../linux/grpc_xds_bazel_python_test_in_docker.sh | 9 ++++----- tools/internal_ci/linux/grpc_xds_bazel_test_in_docker.sh | 3 ++- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/tools/internal_ci/linux/grpc_xds_bazel_python_test_in_docker.sh b/tools/internal_ci/linux/grpc_xds_bazel_python_test_in_docker.sh index d692c5611e4..f3eefec5833 100755 --- a/tools/internal_ci/linux/grpc_xds_bazel_python_test_in_docker.sh +++ b/tools/internal_ci/linux/grpc_xds_bazel_python_test_in_docker.sh @@ -16,11 +16,9 @@ trap 'date' DEBUG set -ex -o igncr || set -ex + mkdir -p /var/local/git -git clone /var/local/jenkins/grpc /var/local/git/grpc -(cd /var/local/jenkins/grpc/ && git submodule foreach 'cd /var/local/git/grpc \ -&& git submodule update --init --reference /var/local/jenkins/grpc/${name} \ -${name}') +git clone -b master --single-branch --depth=1 https://github.com/grpc/grpc.git /var/local/git/grpc cd /var/local/git/grpc python3 -m pip install virtualenv @@ -62,13 +60,14 @@ touch "$TOOLS_DIR"/src/proto/grpc/health/v1/__init__.py --grpc_python_out=${TOOLS_DIR} \ ${HEALTH_PROTO_SOURCE_DIR}/health.proto +cd /var/local/jenkins/grpc/ bazel build //src/python/grpcio_tests/tests_py3_only/interop:xds_interop_client # Test cases "path_matching" and "header_matching" are not included in "all", # because not all interop clients in all languages support these new tests. export PYTHONUNBUFFERED=true GRPC_VERBOSITY=debug GRPC_TRACE=xds_client,xds_resolver,xds_cluster_manager_lb,cds_lb,xds_cluster_resolver_lb,priority_lb,xds_cluster_impl_lb,weighted_target_lb "$PYTHON" \ - tools/run_tests/run_xds_tests.py \ + /var/local/git/grpc/tools/run_tests/run_xds_tests.py \ --halt_after_fail \ --test_case="ping_pong,circuit_breaking" \ --project_id=grpc-testing \ diff --git a/tools/internal_ci/linux/grpc_xds_bazel_test_in_docker.sh b/tools/internal_ci/linux/grpc_xds_bazel_test_in_docker.sh index 90b90a3f8a3..cd820579bdf 100755 --- a/tools/internal_ci/linux/grpc_xds_bazel_test_in_docker.sh +++ b/tools/internal_ci/linux/grpc_xds_bazel_test_in_docker.sh @@ -59,6 +59,7 @@ touch "$TOOLS_DIR"/src/proto/grpc/health/v1/__init__.py --grpc_python_out=${TOOLS_DIR} \ ${HEALTH_PROTO_SOURCE_DIR}/health.proto +cd /var/local/jenkins/grpc/ bazel build test/cpp/interop:xds_interop_client # Test cases "path_matching" and "header_matching" are not included in "all", @@ -67,7 +68,7 @@ bazel build test/cpp/interop:xds_interop_client # TODO: remove "path_matching" and "header_matching" from --test_case after # they are added into "all". GRPC_VERBOSITY=debug GRPC_TRACE=xds_client,xds_resolver,xds_cluster_manager_lb,cds_lb,xds_cluster_resolver_lb,priority_lb,xds_cluster_impl_lb,weighted_target_lb "$PYTHON" \ - tools/run_tests/run_xds_tests.py \ + /var/local/git/grpc/tools/run_tests/run_xds_tests.py \ --halt_after_fail \ --test_case="ping_pong,circuit_breaking" \ --project_id=grpc-testing \