Only copy stuff when status is ok

10 years ago · 3deb0069f4
parent 01ac44bf08
commit 3deb0069f4
1 changed files with 6 additions and 4 deletions
--- a/src/cpp/server/server.cc
+++ b/src/cpp/server/server.cc
@ -368,10 +368,12 @@ Server::GenericAsyncRequest::GenericAsyncRequest(

 bool Server::GenericAsyncRequest::FinalizeResult(void** tag, bool* status) {
  // TODO(yangg) remove the copy here.
-  static_cast<GenericServerContext*>(context_)->method_ = call_details_.method;
-  static_cast<GenericServerContext*>(context_)->host_ = call_details_.host;
-  gpr_free(call_details_.method);
-  gpr_free(call_details_.host);
+  if (*status) {
+    static_cast<GenericServerContext*>(context_)->method_ = call_details_.method;
+    static_cast<GenericServerContext*>(context_)->host_ = call_details_.host;
+    gpr_free(call_details_.method);
+    gpr_free(call_details_.host);
+  }
  return BaseAsyncRequest::FinalizeResult(tag, status);
 }