Reviewer comments

pull/35659/head
Yash Tibrewal 1 year ago
parent cea2c74e58
commit 3da9859dd5
  1. 12
      test/cpp/ext/csm/csm_observability_test.cc
  2. 2
      test/cpp/ext/otel/otel_test_library.cc

@ -32,8 +32,8 @@ namespace testing {
namespace {
TEST(CsmObservabilityBuilderTest, Basic) {
EXPECT_TRUE(
experimental::CsmObservabilityBuilder().BuildAndRegister().status().ok());
EXPECT_EQ(experimental::CsmObservabilityBuilder().BuildAndRegister().status(),
absl::OkStatus());
}
TEST(GsmDependencyTest, GoogleCloudOpenTelemetryDependency) {
@ -64,10 +64,10 @@ TEST(CsmChannelTargetSelectorTest, XdsTargetsWithTDAuthority) {
}
TEST(CsmPluginOptionTest, Basic) {
ASSERT_TRUE(OpenTelemetryPluginBuilder()
.AddPluginOption(MakeCsmOpenTelemetryPluginOption())
.BuildAndRegisterGlobal()
.ok());
EXPECT_EQ(OpenTelemetryPluginBuilder()
.AddPluginOption(MakeCsmOpenTelemetryPluginOption())
.BuildAndRegisterGlobal(),
absl::OkStatus());
}
} // namespace

@ -115,7 +115,7 @@ void OpenTelemetryPluginEnd2EndTest::Init(Options config) {
for (auto& option : config.plugin_options) {
ot_builder.AddPluginOption(std::move(option));
}
ASSERT_TRUE(ot_builder.BuildAndRegisterGlobal().ok());
ASSERT_EQ(ot_builder.BuildAndRegisterGlobal(), absl::OkStatus());
ChannelArguments channel_args;
if (!config.labels_to_inject.empty()) {
labels_to_inject_ = config.labels_to_inject;

Loading…
Cancel
Save