Remove posix_event_engine_polling_enabled experiment (#32037)

* Remove posix_event_engine_polling_enabled experiment

* regenerate projects

bazel/experiments.bzl

@@ -51,9 +51,6 @@ EXPERIMENTS = {
         "endpoint_test": [
             "tcp_read_chunks",
         ],
-        "event_engine_client_test": [
-            "posix_event_engine_enable_polling",
-        ],
         "flow_control_test": [
             "flow_control_fixes",
             "tcp_read_chunks",

src/core/BUILD

@@ -1842,7 +1842,6 @@ grpc_cc_library(
         "event_engine_thread_pool",
         "event_engine_trace",
         "event_engine_utils",
-        "experiments",
         "init_internally",
         "iomgr_port",
         "posix_event_engine_closure",

src/core/lib/event_engine/posix_engine/posix_engine.cc

@@ -41,7 +41,6 @@
 #include "src/core/lib/event_engine/tcp_socket_utils.h"
 #include "src/core/lib/event_engine/trace.h"
 #include "src/core/lib/event_engine/utils.h"
-#include "src/core/lib/experiments/experiments.h"
 #include "src/core/lib/gprpp/sync.h"
 
 #ifdef GRPC_POSIX_SOCKET_TCP
@@ -335,13 +334,11 @@ PosixEventEngine::PosixEventEngine()
     : connection_shards_(std::max(2 * gpr_cpu_num_cores(), 1u)),
       executor_(std::make_shared<ThreadPool>()),
       timer_manager_(executor_) {
-  if (grpc_core::IsPosixEventEngineEnablePollingEnabled()) {
-    poller_manager_ = std::make_shared<PosixEnginePollerManager>(executor_);
-    if (poller_manager_->Poller() != nullptr) {
-      executor_->Run([poller_manager = poller_manager_]() {
-        PollerWorkInternal(poller_manager);
-      });
-    }
+  poller_manager_ = std::make_shared<PosixEnginePollerManager>(executor_);
+  if (poller_manager_->Poller() != nullptr) {
+    executor_->Run([poller_manager = poller_manager_]() {
+      PollerWorkInternal(poller_manager);
+    });
   }
 }
 
@@ -536,11 +533,6 @@ EventEngine::ConnectionHandle PosixEventEngine::Connect(
     const EndpointConfig& args, MemoryAllocator memory_allocator,
     Duration timeout) {
 #ifdef GRPC_POSIX_SOCKET_TCP
-  if (!grpc_core::IsPosixEventEngineEnablePollingEnabled()) {
-    GPR_ASSERT(
-        false &&
-        "EventEngine::Connect is not supported because polling is not enabled");
-  }
   GPR_ASSERT(poller_manager_ != nullptr);
   PosixTcpOptions options = TcpOptionsFromEndpointConfig(args);
   absl::StatusOr<PosixSocketWrapper::PosixSocketCreateResult> socket =

src/core/lib/experiments/experiments.cc

@@ -49,8 +49,6 @@ const char* const description_monitoring_experiment =
 const char* const description_promise_based_client_call =
     "If set, use the new gRPC promise based call code when it's appropriate "
     "(ie when all filters in a stack are promise based)";
-const char* const description_posix_event_engine_enable_polling =
-    "If set, enables polling on the default posix event engine.";
 const char* const description_free_large_allocator =
     "If set, return all free bytes from a \042big\042 allocator";
 }  // namespace
@@ -71,8 +69,6 @@ const ExperimentMetadata g_experiment_metadata[] = {
     {"event_engine_client", description_event_engine_client, false},
     {"monitoring_experiment", description_monitoring_experiment, true},
     {"promise_based_client_call", description_promise_based_client_call, false},
-    {"posix_event_engine_enable_polling",
-     description_posix_event_engine_enable_polling, true},
     {"free_large_allocator", description_free_large_allocator, false},
 };
 

src/core/lib/experiments/experiments.h

@@ -42,10 +42,7 @@ inline bool IsMonitoringExperimentEnabled() { return IsExperimentEnabled(9); }
 inline bool IsPromiseBasedClientCallEnabled() {
   return IsExperimentEnabled(10);
 }
-inline bool IsPosixEventEngineEnablePollingEnabled() {
-  return IsExperimentEnabled(11);
-}
-inline bool IsFreeLargeAllocatorEnabled() { return IsExperimentEnabled(12); }
+inline bool IsFreeLargeAllocatorEnabled() { return IsExperimentEnabled(11); }
 
 struct ExperimentMetadata {
   const char* name;
@@ -53,7 +50,7 @@ struct ExperimentMetadata {
   bool default_value;
 };
 
-constexpr const size_t kNumExperiments = 13;
+constexpr const size_t kNumExperiments = 12;
 extern const ExperimentMetadata g_experiment_metadata[kNumExperiments];
 
 }  // namespace grpc_core

src/core/lib/experiments/experiments.yaml

@@ -120,13 +120,6 @@
   expiry: 2023/01/01
   owner: ctiller@google.com
   test_tags: ["core_end2end_test", "lame_client_test"]
-- name: posix_event_engine_enable_polling
-  description:
-    If set, enables polling on the default posix event engine.
-  default: true
-  expiry: 2023/01/01
-  owner: vigneshbabu@google.com
-  test_tags: ["event_engine_client_test"]
 - name: free_large_allocator
   description:
     If set, return all free bytes from a "big" allocator

test/core/event_engine/posix/posix_event_engine_connect_test.cc

@@ -42,7 +42,6 @@
 #include "src/core/lib/event_engine/channel_args_endpoint_config.h"
 #include "src/core/lib/event_engine/posix_engine/posix_engine.h"
 #include "src/core/lib/event_engine/tcp_socket_utils.h"
-#include "src/core/lib/experiments/experiments.h"
 #include "src/core/lib/gprpp/notification.h"
 #include "src/core/lib/resource_quota/memory_quota.h"
 #include "src/core/lib/resource_quota/resource_quota.h"
@@ -208,9 +207,6 @@ TEST(PosixEventEngineTest, IndefiniteConnectCancellationTest) {
 int main(int argc, char** argv) {
   grpc::testing::TestEnvironment env(&argc, argv);
   ::testing::InitGoogleTest(&argc, argv);
-  if (!grpc_core::IsPosixEventEngineEnablePollingEnabled()) {
-    return 0;
-  }
   grpc_init();
   int ret = RUN_ALL_TESTS();
   grpc_shutdown();

test/core/event_engine/test_suite/posix_event_engine_test.cc

@@ -19,7 +19,6 @@
 #include <grpc/grpc.h>
 
 #include "src/core/lib/event_engine/posix_engine/posix_engine.h"
-#include "src/core/lib/experiments/experiments.h"
 #include "test/core/event_engine/test_suite/event_engine_test.h"
 #include "test/core/event_engine/test_suite/oracle_event_engine_posix.h"
 #include "test/core/util/test_config.h"
@@ -27,9 +26,6 @@
 int main(int argc, char** argv) {
   testing::InitGoogleTest(&argc, argv);
   grpc::testing::TestEnvironment env(&argc, argv);
-  if (!grpc_core::IsPosixEventEngineEnablePollingEnabled()) {
-    return 0;
-  }
   SetEventEngineFactories(
       []() {
         return std::make_unique<