addressed review comments

pull/423/head
Jan Tattermusch 10 years ago
parent 6b7523d5dc
commit 392d1e0cfe
  1. 5
      src/csharp/GrpcCore/Utils/RecordingQueue.cs
  2. 9
      src/csharp/InteropClient/Client.cs
  3. 4
      src/csharp/InteropClient/InteropClient.csproj

@ -5,6 +5,11 @@ using System.Collections.Concurrent;
namespace Google.GRPC.Core.Utils
{
/// <summary>
/// Observer that allows us to await incoming messages one-by-one.
/// The implementation is not ideal and class will be probably replaced
/// by something more versatile in the future.
/// </summary>
public class RecordingQueue<T> : IObserver<T>
{
readonly BlockingCollection<T> queue = new BlockingCollection<T>();

@ -7,9 +7,9 @@ using Google.GRPC.Core.Utils;
using Google.ProtocolBuffers;
using grpc.testing;
namespace InteropClient
namespace Google.GRPC.Interop
{
class InteropClient
class Client
{
private class ClientOptions
{
@ -24,7 +24,8 @@ namespace InteropClient
ClientOptions options;
private InteropClient(ClientOptions options) {
private Client(ClientOptions options)
{
this.options = options;
}
@ -53,7 +54,7 @@ namespace InteropClient
Environment.Exit(1);
}
var interopClient = new InteropClient(options);
var interopClient = new Client(options);
interopClient.Run();
}

@ -9,7 +9,7 @@
<OutputType>Exe</OutputType>
<RootNamespace>InteropClient</RootNamespace>
<AssemblyName>InteropClient</AssemblyName>
<StartupObject>InteropClient.InteropClient</StartupObject>
<StartupObject>Google.GRPC.Interop.Client</StartupObject>
<TargetFrameworkVersion>v4.5</TargetFrameworkVersion>
</PropertyGroup>
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|x86' ">
@ -43,7 +43,7 @@
</ItemGroup>
<ItemGroup>
<Compile Include="Properties\AssemblyInfo.cs" />
<Compile Include="InteropClient.cs" />
<Compile Include="Client.cs" />
</ItemGroup>
<Import Project="$(MSBuildBinPath)\Microsoft.CSharp.targets" />
<ItemGroup>

Loading…
Cancel
Save