Remove overall deadlines in ALTS concurrent connectivity test (#32267)

pull/32272/head
apolcyn 2 years ago committed by GitHub
parent a9e2ef199e
commit 37b78ff514
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 22
      test/core/tsi/alts/handshaker/alts_concurrent_connectivity_test.cc

@ -305,7 +305,6 @@ TEST(AltsConcurrentConnectivityTest, TestConcurrentClientServerHandshakes) {
// Test
{
TestServer test_server;
gpr_timespec test_deadline = grpc_timeout_seconds_to_deadline(20);
size_t num_concurrent_connects = 50;
std::vector<std::unique_ptr<ConnectLoopRunner>> connect_loop_runners;
gpr_log(GPR_DEBUG,
@ -320,9 +319,6 @@ TEST(AltsConcurrentConnectivityTest, TestConcurrentClientServerHandshakes) {
connect_loop_runners.clear();
gpr_log(GPR_DEBUG,
"done performing concurrent expected-to-succeed connects");
if (gpr_time_cmp(gpr_now(GPR_CLOCK_MONOTONIC), test_deadline) > 0) {
grpc_core::Crash("Test took longer than expected.");
}
}
}
@ -350,7 +346,6 @@ TEST(AltsConcurrentConnectivityTest,
grpc_core::testing::FakeUdpAndTcpServer::
CloseSocketUponReceivingBytesFromPeer);
{
gpr_timespec test_deadline = grpc_timeout_seconds_to_deadline(20);
std::vector<std::unique_ptr<ConnectLoopRunner>> connect_loop_runners;
size_t num_concurrent_connects = 100;
gpr_log(GPR_DEBUG, "start performing concurrent expected-to-fail connects");
@ -363,11 +358,6 @@ TEST(AltsConcurrentConnectivityTest,
}
connect_loop_runners.clear();
gpr_log(GPR_DEBUG, "done performing concurrent expected-to-fail connects");
if (gpr_time_cmp(gpr_now(GPR_CLOCK_MONOTONIC), test_deadline) > 0) {
grpc_core::Crash(
"Exceeded test deadline. ALTS handshakes might not be failing "
"fast when the peer endpoint closes the connection abruptly");
}
}
}
@ -388,7 +378,6 @@ TEST(AltsConcurrentConnectivityTest,
kWaitForClientToSendFirstBytes,
grpc_core::testing::FakeUdpAndTcpServer::CloseSocketUponCloseFromPeer);
{
gpr_timespec test_deadline = grpc_timeout_seconds_to_deadline(20);
std::vector<std::unique_ptr<ConnectLoopRunner>> connect_loop_runners;
size_t num_concurrent_connects = 100;
gpr_log(GPR_DEBUG, "start performing concurrent expected-to-fail connects");
@ -401,11 +390,6 @@ TEST(AltsConcurrentConnectivityTest,
}
connect_loop_runners.clear();
gpr_log(GPR_DEBUG, "done performing concurrent expected-to-fail connects");
if (gpr_time_cmp(gpr_now(GPR_CLOCK_MONOTONIC), test_deadline) > 0) {
grpc_core::Crash(
"Exceeded test deadline. ALTS handshakes might not be failing "
"fast when the handshake server closes new connections");
}
}
}
@ -426,7 +410,6 @@ TEST(AltsConcurrentConnectivityTest,
kWaitForClientToSendFirstBytes,
grpc_core::testing::FakeUdpAndTcpServer::CloseSocketUponCloseFromPeer);
{
gpr_timespec test_deadline = grpc_timeout_seconds_to_deadline(20);
std::vector<std::unique_ptr<ConnectLoopRunner>> connect_loop_runners;
size_t num_concurrent_connects = 100;
gpr_log(GPR_DEBUG, "start performing concurrent expected-to-fail connects");
@ -439,11 +422,6 @@ TEST(AltsConcurrentConnectivityTest,
}
connect_loop_runners.clear();
gpr_log(GPR_DEBUG, "done performing concurrent expected-to-fail connects");
if (gpr_time_cmp(gpr_now(GPR_CLOCK_MONOTONIC), test_deadline) > 0) {
grpc_core::Crash(
"Exceeded test deadline. ALTS handshakes might not be failing "
"fast when the handshake server is non-response timeout occurs");
}
}
}

Loading…
Cancel
Save