From 369a04ace686d2db7fff8a39473680566da6700a Mon Sep 17 00:00:00 2001 From: Sree Kuchibhotla Date: Mon, 1 Feb 2016 10:53:13 -0800 Subject: [PATCH] Address code review comments --- src/cpp/server/server_context.cc | 2 +- test/cpp/end2end/async_end2end_test.cc | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/cpp/server/server_context.cc b/src/cpp/server/server_context.cc index 4a5ac5af926..e205a1969b3 100644 --- a/src/cpp/server/server_context.cc +++ b/src/cpp/server/server_context.cc @@ -177,7 +177,7 @@ void ServerContext::TryCancel() const { grpc_call_error err = grpc_call_cancel_with_status( call_, GRPC_STATUS_CANCELLED, "Cancelled on the server side", NULL); if (err != GRPC_CALL_OK) { - gpr_log(GPR_INFO, "TryCancel failed with: %d", err); + gpr_log(GPR_ERROR, "TryCancel failed with: %d", err); } } diff --git a/test/cpp/end2end/async_end2end_test.cc b/test/cpp/end2end/async_end2end_test.cc index 0deb2eff95b..252bda37988 100644 --- a/test/cpp/end2end/async_end2end_test.cc +++ b/test/cpp/end2end/async_end2end_test.cc @@ -884,13 +884,12 @@ class AsyncEnd2endServerTryCancelTest : public AsyncEnd2endTest { // Server sends the final message and cancelled status (but the RPC is // already cancelled at this point. So we expect the operation to fail) - send_response.set_message("Pong"); srv_stream.Finish(send_response, Status::CANCELLED, tag(9)); Verifier(GetParam()).Expect(9, false).Verify(cq_.get()); // Client will see the cancellation cli_stream->Finish(&recv_status, tag(10)); - // TODO: sreek: The expectation here should be true. This is a bug (github + // TODO(sreek): The expectation here should be true. This is a bug (github // issue #4972) Verifier(GetParam()).Expect(10, false).Verify(cq_.get()); EXPECT_FALSE(recv_status.ok());