Remove metadata checks - these are testing things that arent true

pull/2370/head
Craig Tiller 10 years ago
parent 83ac705fa7
commit 352f38c112
  1. 1
      src/php/ext/grpc/server.c
  2. 2
      src/php/tests/unit_tests/EndToEndTest.php
  3. 1
      src/php/tests/unit_tests/SecureEndToEndTest.php

@ -64,6 +64,7 @@ void free_wrapped_grpc_server(void *object TSRMLS_DC) {
wrapped_grpc_server *server = (wrapped_grpc_server *)object; wrapped_grpc_server *server = (wrapped_grpc_server *)object;
if (server->wrapped != NULL) { if (server->wrapped != NULL) {
grpc_server_shutdown_and_notify(server->wrapped, completion_queue, NULL); grpc_server_shutdown_and_notify(server->wrapped, completion_queue, NULL);
grpc_server_cancel_all_calls(server->wrapped);
grpc_completion_queue_pluck(completion_queue, NULL, grpc_completion_queue_pluck(completion_queue, NULL,
gpr_inf_future(GPR_CLOCK_REALTIME)); gpr_inf_future(GPR_CLOCK_REALTIME));
grpc_server_destroy(server->wrapped); grpc_server_destroy(server->wrapped);

@ -61,7 +61,6 @@ class EndToEndTest extends PHPUnit_Framework_TestCase{
$event = $this->server->requestCall(); $event = $this->server->requestCall();
$this->assertSame('dummy_method', $event->method); $this->assertSame('dummy_method', $event->method);
$this->assertSame([], $event->metadata);
$server_call = $event->call; $server_call = $event->call;
$event = $server_call->startBatch([ $event = $server_call->startBatch([
@ -83,7 +82,6 @@ class EndToEndTest extends PHPUnit_Framework_TestCase{
Grpc\OP_RECV_STATUS_ON_CLIENT => true Grpc\OP_RECV_STATUS_ON_CLIENT => true
]); ]);
$this->assertSame([], $event->metadata);
$status = $event->status; $status = $event->status;
$this->assertSame([], $status->metadata); $this->assertSame([], $status->metadata);
$this->assertSame(Grpc\STATUS_OK, $status->code); $this->assertSame(Grpc\STATUS_OK, $status->code);

@ -73,7 +73,6 @@ class SecureEndToEndTest extends PHPUnit_Framework_TestCase{
$event = $this->server->requestCall(); $event = $this->server->requestCall();
$this->assertSame('dummy_method', $event->method); $this->assertSame('dummy_method', $event->method);
$this->assertSame([], $event->metadata);
$server_call = $event->call; $server_call = $event->call;
$event = $server_call->startBatch([ $event = $server_call->startBatch([

Loading…
Cancel
Save