From 34d77aae5ec26063e2eb5dc4b47ba4dce90c7136 Mon Sep 17 00:00:00 2001 From: Yash Tibrewal Date: Mon, 7 Jan 2019 14:12:03 -0800 Subject: [PATCH] Always nullify serializer to free memory --- include/grpcpp/impl/codegen/call_op_set.h | 2 +- include/grpcpp/impl/codegen/interceptor_common.h | 4 +--- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/include/grpcpp/impl/codegen/call_op_set.h b/include/grpcpp/impl/codegen/call_op_set.h index 2c34082ebb1..880c62344b8 100644 --- a/include/grpcpp/impl/codegen/call_op_set.h +++ b/include/grpcpp/impl/codegen/call_op_set.h @@ -324,8 +324,8 @@ class CallOpSendMessage { } if (msg_ != nullptr) { GPR_CODEGEN_ASSERT(serializer_(msg_).ok()); - serializer_ = nullptr; } + serializer_ = nullptr; grpc_op* op = &ops[(*nops)++]; op->op = GRPC_OP_SEND_MESSAGE; op->flags = write_options_.flags(); diff --git a/include/grpcpp/impl/codegen/interceptor_common.h b/include/grpcpp/impl/codegen/interceptor_common.h index 33e46389b3d..09721343ffa 100644 --- a/include/grpcpp/impl/codegen/interceptor_common.h +++ b/include/grpcpp/impl/codegen/interceptor_common.h @@ -98,9 +98,7 @@ class InterceptorBatchMethodsImpl *orig_send_message_ = message; } - bool GetSendMessageStatus() override { - return !*fail_send_message_; - } + bool GetSendMessageStatus() override { return !*fail_send_message_; } std::multimap* GetSendInitialMetadata() override { return send_initial_metadata_;