mirror of https://github.com/grpc/grpc.git
[grpc_error] remove unnecessary status attributes (#36523)
The following attributes were completely unused:
- kOffset
- kIndex
- kSize
- kFilename
- kKey
- kValue
The following attributes were added but never programmatically accessed, and I've moved them into the status messages themselves, which is another step toward #22883:
- kErrorNo
- kTsiCode
- kWsaError
- kHttpStatus
- kOsError
- kSyscall
- kTargetAddress
- kRawBytes
- kTsiError
Closes #36523
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36523 from markdroth:grpc_error_attribute_cleanup b289c399fe
PiperOrigin-RevId: 639147583
pull/36791/head
Mark D. Roth
6 months ago
committed by
Copybara-Service
parent
53540ae5d6
commit
34ac4ee5de
41 changed files with 180 additions and 391 deletions
@ -1,31 +0,0 @@ |
||||
//
|
||||
//
|
||||
// Copyright 2015 gRPC authors.
|
||||
//
|
||||
// Licensed under the Apache License, Version 2.0 (the "License");
|
||||
// you may not use this file except in compliance with the License.
|
||||
// You may obtain a copy of the License at
|
||||
//
|
||||
// http://www.apache.org/licenses/LICENSE-2.0
|
||||
//
|
||||
// Unless required by applicable law or agreed to in writing, software
|
||||
// distributed under the License is distributed on an "AS IS" BASIS,
|
||||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||
// See the License for the specific language governing permissions and
|
||||
// limitations under the License.
|
||||
//
|
||||
//
|
||||
|
||||
#include "src/core/handshaker/security/tsi_error.h" |
||||
|
||||
#include <grpc/support/port_platform.h> |
||||
|
||||
#include "src/core/lib/gprpp/status_helper.h" |
||||
|
||||
grpc_error_handle grpc_set_tsi_error_result(grpc_error_handle error, |
||||
tsi_result result) { |
||||
return grpc_error_set_int( |
||||
grpc_error_set_str(error, grpc_core::StatusStrProperty::kTsiError, |
||||
tsi_result_to_string(result)), |
||||
grpc_core::StatusIntProperty::kTsiCode, result); |
||||
} |
||||
@ -1,30 +0,0 @@ |
||||
//
|
||||
//
|
||||
// Copyright 2015 gRPC authors.
|
||||
//
|
||||
// Licensed under the Apache License, Version 2.0 (the "License");
|
||||
// you may not use this file except in compliance with the License.
|
||||
// You may obtain a copy of the License at
|
||||
//
|
||||
// http://www.apache.org/licenses/LICENSE-2.0
|
||||
//
|
||||
// Unless required by applicable law or agreed to in writing, software
|
||||
// distributed under the License is distributed on an "AS IS" BASIS,
|
||||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||
// See the License for the specific language governing permissions and
|
||||
// limitations under the License.
|
||||
//
|
||||
//
|
||||
|
||||
#ifndef GRPC_SRC_CORE_HANDSHAKER_SECURITY_TSI_ERROR_H |
||||
#define GRPC_SRC_CORE_HANDSHAKER_SECURITY_TSI_ERROR_H |
||||
|
||||
#include <grpc/support/port_platform.h> |
||||
|
||||
#include "src/core/lib/iomgr/error.h" |
||||
#include "src/core/tsi/transport_security_interface.h" |
||||
|
||||
grpc_error_handle grpc_set_tsi_error_result(grpc_error_handle error, |
||||
tsi_result result); |
||||
|
||||
#endif // GRPC_SRC_CORE_HANDSHAKER_SECURITY_TSI_ERROR_H
|
||||
Loading…
Reference in new issue