address review comments

pull/16937/head
Jan Tattermusch 6 years ago
parent 6b5f1143fc
commit 32495f4cee
  1. 2
      tools/internal_ci/linux/grpc_interop_matrix.sh
  2. 6
      tools/interop_matrix/run_interop_matrix_tests.py

@ -22,4 +22,4 @@ cd $(dirname $0)/../../..
source tools/internal_ci/helper_scripts/prepare_build_linux_rc
tools/interop_matrix/run_interop_matrix_tests.py $RUN_TESTS_FLAGS
tools/interop_matrix/run_interop_matrix_tests.py $RUN_TESTS_FLAGS

@ -165,6 +165,8 @@ def _generate_test_case_jobspecs(lang, runtime, release, suite_name):
job_spec_list = []
for line in testcase_lines:
# TODO(jtattermusch): revisit the logic for updating test case commands
# what it currently being done seems fragile.
m = re.search('--test_case=(.*)"', line)
shortname = m.group(1) if m else 'unknown_test'
m = re.search('--server_host_override=(.*).sandbox.googleapis.com',
@ -198,8 +200,8 @@ def _pull_images_for_lang(lang, images):
download_specs = []
for release, image in images:
# Pull the image and warm it up.
# First time we use an image with "docker run", it takes time to unpack the image
# and later this delay would fail our test cases.
# First time we use an image with "docker run", it takes time to unpack
# the image and later this delay would fail our test cases.
cmdline = [
'gcloud docker -- pull %s && docker run --rm=true %s /bin/true' %
(image, image)

Loading…
Cancel
Save