From 9788a9a8359ad81efb57a06fffdbeaef87818743 Mon Sep 17 00:00:00 2001 From: Lidi Zheng Date: Mon, 25 Nov 2019 10:50:59 -0800 Subject: [PATCH 1/2] Add side-products of Python compilation to gitignore --- .gitignore | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.gitignore b/.gitignore index 06e8706f9a8..e088c2c3b58 100644 --- a/.gitignore +++ b/.gitignore @@ -19,6 +19,8 @@ py27_gevent/ py27_native/ py3[0-9]_gevent/ py3[0-9]_native/ +a.out +src/python/grpcio_*/LICENSE # Node installation output node_modules From bb381872210f8fa9edb716a0762f2795261664ac Mon Sep 17 00:00:00 2001 From: Lidi Zheng Date: Tue, 26 Nov 2019 11:18:00 -0800 Subject: [PATCH 2/2] Add a TODO to remove a.out --- src/python/grpcio/commands.py | 1 + 1 file changed, 1 insertion(+) diff --git a/src/python/grpcio/commands.py b/src/python/grpcio/commands.py index d189c2869d0..a31c9730661 100644 --- a/src/python/grpcio/commands.py +++ b/src/python/grpcio/commands.py @@ -217,6 +217,7 @@ class BuildExt(build_ext.build_ext): """Test if default compiler is okay with specifying c++ version when invoked in C mode. GCC is okay with this, while clang is not. """ + # TODO(lidiz) Remove the generated a.out for success tests. cc_test = subprocess.Popen( ['cc', '-x', 'c', '-std=c++11', '-'], stdin=subprocess.PIPE,