Add missing argument

pull/17220/head
Yash Tibrewal 6 years ago
parent bb303513dc
commit 31a775b425
  1. 3
      include/grpcpp/impl/codegen/call_op_set.h
  2. 1
      include/grpcpp/impl/codegen/interceptor_common.h
  3. 8
      test/cpp/end2end/client_interceptors_end2end_test.cc

@ -340,12 +340,11 @@ class CallOpSendMessage {
if (send_buf_.Valid()) {
interceptor_methods->AddInterceptionHookPoint(
experimental::InterceptionHookPoints::POST_SEND_MESSAGE);
// We had already registered failed_send_ earlier. No need to do it again.
}
send_buf_.Clear();
// The contents of the SendMessage value that was previously set
// has had its references stolen by core's operations
interceptor_methods->SetSendMessage(nullptr);
interceptor_methods->SetSendMessage(nullptr, &failed_send_);
}
void SetHijackingState(InterceptorBatchMethodsImpl* interceptor_methods) {

@ -403,6 +403,7 @@ class CancelInterceptorBatchMethods
false &&
"It is illegal to call GetSendMessageStatus on a method which "
"has a Cancel notification");
return false;
}
std::multimap<grpc::string, grpc::string>* GetSendInitialMetadata() override {

@ -580,11 +580,9 @@ TEST_F(ClientInterceptorsStreamingEnd2endTest, ServerStreamingTest) {
TEST_F(ClientInterceptorsStreamingEnd2endTest, ClientStreamingHijackingTest) {
ChannelArguments args;
auto creators = std::unique_ptr<std::vector<
std::unique_ptr<experimental::ClientInterceptorFactoryInterface>>>(
new std::vector<
std::unique_ptr<experimental::ClientInterceptorFactoryInterface>>());
creators->push_back(
std::vector<std::unique_ptr<experimental::ClientInterceptorFactoryInterface>>
creators;
creators.push_back(
std::unique_ptr<ClientStreamingRpcHijackingInterceptorFactory>(
new ClientStreamingRpcHijackingInterceptorFactory()));
auto channel = experimental::CreateCustomChannelWithInterceptors(

Loading…
Cancel
Save