Merge pull request #11399 from yang-g/status_ok_message

Update comments to discourage having an OK status with error_message
reviewable/pr11336/r7^2
Yang Gao 8 years ago committed by GitHub
commit 2f6715d49b
  1. 7
      include/grpc++/impl/codegen/status.h

@ -47,11 +47,14 @@ class Status {
/// Construct an OK instance. /// Construct an OK instance.
Status() : code_(StatusCode::OK) {} Status() : code_(StatusCode::OK) {}
/// Construct an instance with associated \a code and \a error_message /// Construct an instance with associated \a code and \a error_message.
/// It is an error to construct an OK status with non-empty \a error_message.
Status(StatusCode code, const grpc::string& error_message) Status(StatusCode code, const grpc::string& error_message)
: code_(code), error_message_(error_message) {} : code_(code), error_message_(error_message) {}
/// Construct an instance with \a code, \a error_message and \a error_details /// Construct an instance with \a code, \a error_message and
/// \a error_details. It is an error to construct an OK status with non-empty
/// \a error_message and/or \a error_details.
Status(StatusCode code, const grpc::string& error_message, Status(StatusCode code, const grpc::string& error_message,
const grpc::string& error_details) const grpc::string& error_details)
: code_(code), : code_(code),

Loading…
Cancel
Save