Merge pull request #7156 from stanley-cheung/php-add-comment-shutdown-warning

PHP: add warning about shutdown function
pull/7283/merge
kpayson64 9 years ago committed by GitHub
commit 2bece9e0e1
  1. 2
      examples/php/composer.json
  2. 1
      src/php/composer.json
  3. 2
      src/php/ext/grpc/php_grpc.c

@ -9,6 +9,6 @@
}
],
"require": {
"grpc/grpc": "dev-release-0_13"
"grpc/grpc": "v0.15.0"
}
}

@ -2,7 +2,6 @@
"name": "grpc/grpc",
"type": "library",
"description": "gRPC library for PHP",
"version": "0.14.0",
"keywords": ["rpc"],
"homepage": "http://grpc.io",
"license": "BSD-3-Clause",

@ -248,6 +248,8 @@ PHP_MSHUTDOWN_FUNCTION(grpc) {
/* uncomment this line if you have INI entries
UNREGISTER_INI_ENTRIES();
*/
// WARNING: This function IS being called by PHP when the extension
// is unloaded but the logs were somehow suppressed.
grpc_shutdown_timeval(TSRMLS_C);
grpc_php_shutdown_completion_queue(TSRMLS_C);
grpc_shutdown();

Loading…
Cancel
Save