Minor changes to match recent design changes

pull/2322/head
murgatroid99 10 years ago
parent d046cc6de5
commit 2be6ac0dc1
  1. 2
      src/node/health_check/health.js
  2. 2
      src/node/health_check/health.proto
  3. 4
      src/node/test/health_test.js

@ -51,7 +51,7 @@ HealthImplementation.prototype.setStatus = function(service, status) {
HealthImplementation.prototype.check = function(call, callback){ HealthImplementation.prototype.check = function(call, callback){
var service = call.request.service; var service = call.request.service;
callback(null, {status: _.get(this.statusMap, service, 'UNSPECIFIED')}); callback(null, {status: _.get(this.statusMap, service, 'UNKNOWN')});
}; };
module.exports = { module.exports = {

@ -37,7 +37,7 @@ message HealthCheckRequest {
message HealthCheckResponse { message HealthCheckResponse {
enum ServingStatus { enum ServingStatus {
UNSPECIFIED = 0; UNKNOWN = 0;
SERVING = 1; SERVING = 1;
NOT_SERVING = 2; NOT_SERVING = 2;
} }

@ -80,11 +80,11 @@ describe('Health Checking', function() {
done(); done();
}); });
}); });
it('should respond with UNSPECIFIED for an unknown service', function(done) { it('should respond with UNKNOWN for an unknown service', function(done) {
healthClient.check({service: 'unknown.service.Name'}, healthClient.check({service: 'unknown.service.Name'},
function(err, response) { function(err, response) {
assert.ifError(err); assert.ifError(err);
assert.strictEqual(response.status, 'UNSPECIFIED'); assert.strictEqual(response.status, 'UNKNOWN');
done(); done();
}); });
}); });

Loading…
Cancel
Save