[experiment] Disable work_serializer_dispatch (#37195)

Causes crashes during shutdown.

<!--

If you know who should review your pull request, please assign it to that
person, otherwise the pull request would get assigned randomly.

If your pull request is for a specific language, please add the appropriate
lang label.

-->

Closes #37195

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/37195 from yousukseung:work-serializer-dispatch-disable 781bc59384
PiperOrigin-RevId: 650741850
pull/37104/head
Yousuk Seung 8 months ago committed by Copybara-Service
parent 267ff3c848
commit 297743e028
  1. 16
      bazel/experiments.bzl
  2. 2
      src/core/lib/experiments/experiments.cc
  3. 3
      src/core/lib/experiments/experiments.h
  4. 2
      src/core/lib/experiments/rollouts.yaml

@ -135,6 +135,10 @@ EXPERIMENTS = {
"off": { "off": {
"core_end2end_test": [ "core_end2end_test": [
"event_engine_client", "event_engine_client",
"work_serializer_dispatch",
],
"cpp_end2end_test": [
"work_serializer_dispatch",
], ],
"endpoint_test": [ "endpoint_test": [
"tcp_frame_size_tuning", "tcp_frame_size_tuning",
@ -150,10 +154,16 @@ EXPERIMENTS = {
"tcp_frame_size_tuning", "tcp_frame_size_tuning",
"tcp_rcv_lowat", "tcp_rcv_lowat",
], ],
"lb_unit_test": [
"work_serializer_dispatch",
],
"resource_quota_test": [ "resource_quota_test": [
"free_large_allocator", "free_large_allocator",
"unconstrained_max_quota_buffer_size", "unconstrained_max_quota_buffer_size",
], ],
"xds_end2end_test": [
"work_serializer_dispatch",
],
}, },
"on": { "on": {
"cancel_ares_query_test": [ "cancel_ares_query_test": [
@ -161,10 +171,6 @@ EXPERIMENTS = {
], ],
"core_end2end_test": [ "core_end2end_test": [
"event_engine_listener", "event_engine_listener",
"work_serializer_dispatch",
],
"cpp_end2end_test": [
"work_serializer_dispatch",
], ],
"cpp_lb_end2end_test": [ "cpp_lb_end2end_test": [
"pick_first_new", "pick_first_new",
@ -174,14 +180,12 @@ EXPERIMENTS = {
], ],
"lb_unit_test": [ "lb_unit_test": [
"pick_first_new", "pick_first_new",
"work_serializer_dispatch",
], ],
"resolver_component_tests_runner_invoker": [ "resolver_component_tests_runner_invoker": [
"event_engine_dns", "event_engine_dns",
], ],
"xds_end2end_test": [ "xds_end2end_test": [
"pick_first_new", "pick_first_new",
"work_serializer_dispatch",
], ],
}, },
}, },

@ -465,7 +465,7 @@ const ExperimentMetadata g_experiment_metadata[] = {
additional_constraints_work_serializer_clears_time_cache, nullptr, 0, true, additional_constraints_work_serializer_clears_time_cache, nullptr, 0, true,
true}, true},
{"work_serializer_dispatch", description_work_serializer_dispatch, {"work_serializer_dispatch", description_work_serializer_dispatch,
additional_constraints_work_serializer_dispatch, nullptr, 0, true, true}, additional_constraints_work_serializer_dispatch, nullptr, 0, false, true},
}; };
} // namespace grpc_core } // namespace grpc_core

@ -152,8 +152,7 @@ inline bool IsTraceRecordCallopsEnabled() { return true; }
inline bool IsUnconstrainedMaxQuotaBufferSizeEnabled() { return false; } inline bool IsUnconstrainedMaxQuotaBufferSizeEnabled() { return false; }
#define GRPC_EXPERIMENT_IS_INCLUDED_WORK_SERIALIZER_CLEARS_TIME_CACHE #define GRPC_EXPERIMENT_IS_INCLUDED_WORK_SERIALIZER_CLEARS_TIME_CACHE
inline bool IsWorkSerializerClearsTimeCacheEnabled() { return true; } inline bool IsWorkSerializerClearsTimeCacheEnabled() { return true; }
#define GRPC_EXPERIMENT_IS_INCLUDED_WORK_SERIALIZER_DISPATCH inline bool IsWorkSerializerDispatchEnabled() { return false; }
inline bool IsWorkSerializerDispatchEnabled() { return true; }
#endif #endif
#else #else

@ -110,6 +110,6 @@
default: default:
# TODO(ysseung): Not fully tested. # TODO(ysseung): Not fully tested.
ios: broken ios: broken
posix: true posix: false
# TODO(ysseung): Test flakes not fully resolved. # TODO(ysseung): Test flakes not fully resolved.
windows: broken windows: broken

Loading…
Cancel
Save