From 8031a0a7ab3c36dcf9dcce4e507b1f25ff7718f6 Mon Sep 17 00:00:00 2001 From: Karthik Ravi Shankar Date: Thu, 19 Sep 2019 11:43:28 -0700 Subject: [PATCH] Make grpc++_base and grpc++_base_unsecure use the correct dependencies 1) src/cpp/client/channel_cc.cc uses ::grpc::g_core_codegen_interface. 2) GRPCXX_SRCS includes src/cpp/client/channel_cc.cc 3) "grpc++_codegen_base_src" contains src/cpp/codegen/codegen_init.cc which has ::grpc::g_core_codegen_interface. 3) "grpc++_base" and "grpc++_base_unsecure" includes GRPCXX_SRCS. 4) But, "grpc++_base" and "grpc++_base_unsecure" don't include "grpc++_codegen_base_src" at all which creates unsatisfied linker error in some targets unless they depend on "grpc++_codegen_base_src" themselves. Solution: Make "grpc++_base" and "grpc++_base_unsecure" depend upon "grpc++_codegen_base_src". --- BUILD | 2 ++ 1 file changed, 2 insertions(+) diff --git a/BUILD b/BUILD index 9a4c85b26e0..080f5331e87 100644 --- a/BUILD +++ b/BUILD @@ -1958,6 +1958,7 @@ grpc_cc_library( deps = [ "grpc", "grpc++_codegen_base", + "grpc++_codegen_base_src", "grpc_health_upb", ], ) @@ -1970,6 +1971,7 @@ grpc_cc_library( public_hdrs = GRPCXX_PUBLIC_HDRS, deps = [ "grpc++_codegen_base", + "grpc++_codegen_base_src", "grpc_health_upb", "grpc_unsecure", ],