PR comments, round 4

reviewable/pr13932/r6
David Garcia Quintas 7 years ago
parent be1b7f986e
commit 269ee29e03
  1. 4
      src/core/ext/filters/client_channel/lb_policy/grpclb/grpclb.cc

@ -935,7 +935,7 @@ static void glb_shutdown_locked(grpc_lb_policy* pol,
} }
gpr_free(pp); gpr_free(pp);
} else { } else {
pp->pick->connected_subchannel.reset(nullptr); pp->pick->connected_subchannel.reset();
GRPC_CLOSURE_SCHED(&pp->on_complete, GRPC_ERROR_REF(error)); GRPC_CLOSURE_SCHED(&pp->on_complete, GRPC_ERROR_REF(error));
} }
pp = next; pp = next;
@ -972,7 +972,7 @@ static void glb_cancel_pick_locked(grpc_lb_policy* pol,
while (pp != nullptr) { while (pp != nullptr) {
pending_pick* next = pp->next; pending_pick* next = pp->next;
if (pp->pick == pick) { if (pp->pick == pick) {
pick->connected_subchannel.reset(nullptr); pick->connected_subchannel.reset();
GRPC_CLOSURE_SCHED(&pp->on_complete, GRPC_CLOSURE_SCHED(&pp->on_complete,
GRPC_ERROR_CREATE_REFERENCING_FROM_STATIC_STRING( GRPC_ERROR_CREATE_REFERENCING_FROM_STATIC_STRING(
"Pick Cancelled", &error, 1)); "Pick Cancelled", &error, 1));

Loading…
Cancel
Save