Chiebot-Mirror
/
grpc
mirror of https://github.com/grpc/grpc.git
8
0
Fork 0
Code Issues Projects Releases Wiki Activity

[StatsPlugin] Some more benchmarks and fixes (#37299)

Browse Source 
```
-------------------------------------------------------------------------------------
Benchmark                                           Time             CPU   Iterations
-------------------------------------------------------------------------------------
BM_AddCounterWithFakeStatsPlugin                 36.9 ns         36.9 ns     18606645
BM_AddCounterWithLabelsWithFakeStatsPlugin        407 ns          407 ns      1712866
BM_AddCounterWithOTelPlugin                      46.6 ns         46.6 ns     15022711
BM_AddCounterWithLabelsWithOTelPlugin             142 ns          142 ns      4957733
BM_AddCounterWithNoPlugin                       0.313 ns        0.313 ns   1000000000
BM_AddCounterWithLabelsWithNoPlugin              1.96 ns         1.96 ns    356217818
```

Closes #37299

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/37299 from yashykt:BMStatsPlugin b4ad53e22b
PiperOrigin-RevId: 655361009
pull/37269/head
Yash Tibrewal 6 months ago committed by Copybara-Service
parent eb2ed3e4da
commit 25dea6e8cc
2 changed files with 120 additions and 44 deletions
Whitespace
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Split View
Diff Options
Show Stats Download Patch File Download Diff File
  1. 84
      test/core/test_util/fake_stats_plugin.h
  2. 80
      test/cpp/microbenchmarks/bm_stats_plugin.cc

84
test/core/test_util/fake_stats_plugin.h
Unescape View File

@ -225,8 +225,8 @@ class FakeStatsPlugin : public StatsPlugin {
descriptor) {
if (!use_disabled_by_default_metrics &&
!descriptor.enable_by_default) {
LOG(INFO) << "FakeStatsPlugin[" << this
<< "]: skipping disabled metric: " << descriptor.name;
VLOG(2) << "FakeStatsPlugin[" << this
<< "]: skipping disabled metric: " << descriptor.name;
return;
}
switch (descriptor.instrument_type) {
@ -300,12 +300,11 @@ class FakeStatsPlugin : public StatsPlugin {
// just ignore it here. This would also prevent us from having to lock the
// GlobalInstrumentsRegistry everytime a metric is recorded. But this is not
// a concern for now.
LOG(INFO) << "FakeStatsPlugin[" << this
<< "]::AddCounter(index=" << handle.index << ", value=(uint64)"
<< value << ", label_values={"
<< absl::StrJoin(label_values, ", ")
<< "}, optional_label_values={"
<< absl::StrJoin(optional_values, ", ") << "}";
VLOG(2) << "FakeStatsPlugin[" << this
<< "]::AddCounter(index=" << handle.index << ", value=(uint64)"
<< value << ", label_values={" << absl::StrJoin(label_values, ", ")
<< "}, optional_label_values={"
<< absl::StrJoin(optional_values, ", ") << "}";
MutexLock lock(&mu_);
auto iter = uint64_counters_.find(handle.index);
if (iter == uint64_counters_.end()) return;
@ -315,12 +314,11 @@ class FakeStatsPlugin : public StatsPlugin {
GlobalInstrumentsRegistry::GlobalInstrumentHandle handle, double value,
absl::Span<const absl::string_view> label_values,
absl::Span<const absl::string_view> optional_values) override {
LOG(INFO) << "FakeStatsPlugin[" << this
<< "]::AddCounter(index=" << handle.index
<< ", value(double)=" << value << ", label_values={"
<< absl::StrJoin(label_values, ", ")
<< "}, optional_label_values={"
<< absl::StrJoin(optional_values, ", ") << "}";
VLOG(2) << "FakeStatsPlugin[" << this
<< "]::AddCounter(index=" << handle.index
<< ", value(double)=" << value << ", label_values={"
<< absl::StrJoin(label_values, ", ") << "}, optional_label_values={"
<< absl::StrJoin(optional_values, ", ") << "}";
MutexLock lock(&mu_);
auto iter = double_counters_.find(handle.index);
if (iter == double_counters_.end()) return;
@ -330,12 +328,11 @@ class FakeStatsPlugin : public StatsPlugin {
GlobalInstrumentsRegistry::GlobalInstrumentHandle handle, uint64_t value,
absl::Span<const absl::string_view> label_values,
absl::Span<const absl::string_view> optional_values) override {
LOG(INFO) << "FakeStatsPlugin[" << this
<< "]::RecordHistogram(index=" << handle.index
<< ", value=(uint64)" << value << ", label_values={"
<< absl::StrJoin(label_values, ", ")
<< "}, optional_label_values={"
<< absl::StrJoin(optional_values, ", ") << "}";
VLOG(2) << "FakeStatsPlugin[" << this
<< "]::RecordHistogram(index=" << handle.index << ", value=(uint64)"
<< value << ", label_values={" << absl::StrJoin(label_values, ", ")
<< "}, optional_label_values={"
<< absl::StrJoin(optional_values, ", ") << "}";
MutexLock lock(&mu_);
auto iter = uint64_histograms_.find(handle.index);
if (iter == uint64_histograms_.end()) return;
@ -345,25 +342,24 @@ class FakeStatsPlugin : public StatsPlugin {
GlobalInstrumentsRegistry::GlobalInstrumentHandle handle, double value,
absl::Span<const absl::string_view> label_values,
absl::Span<const absl::string_view> optional_values) override {
LOG(INFO) << "FakeStatsPlugin[" << this
<< "]::RecordHistogram(index=" << handle.index
<< ", value=(double)" << value << ", label_values={"
<< absl::StrJoin(label_values, ", ")
<< "}, optional_label_values={"
<< absl::StrJoin(optional_values, ", ") << "}";
VLOG(2) << "FakeStatsPlugin[" << this
<< "]::RecordHistogram(index=" << handle.index << ", value=(double)"
<< value << ", label_values={" << absl::StrJoin(label_values, ", ")
<< "}, optional_label_values={"
<< absl::StrJoin(optional_values, ", ") << "}";
MutexLock lock(&mu_);
auto iter = double_histograms_.find(handle.index);
if (iter == double_histograms_.end()) return;
iter->second.Record(value, label_values, optional_values);
}
void AddCallback(RegisteredMetricCallback* callback) override {
LOG(INFO) << "FakeStatsPlugin[" << this << "]::AddCallback(" << callback
<< ")";
VLOG(2) << "FakeStatsPlugin[" << this << "]::AddCallback(" << callback
<< ")";
callbacks_.insert(callback);
}
void RemoveCallback(RegisteredMetricCallback* callback) override {
LOG(INFO) << "FakeStatsPlugin[" << this << "]::RemoveCallback(" << callback
<< ")";
VLOG(2) << "FakeStatsPlugin[" << this << "]::RemoveCallback(" << callback
<< ")";
callbacks_.erase(callback);
}
@ -428,12 +424,12 @@ class FakeStatsPlugin : public StatsPlugin {
return iter->second.GetValues(label_values, optional_values);
}
void TriggerCallbacks() {
LOG(INFO) << "FakeStatsPlugin[" << this << "]::TriggerCallbacks(): START";
VLOG(2) << "FakeStatsPlugin[" << this << "]::TriggerCallbacks(): START";
Reporter reporter(*this);
for (auto* callback : callbacks_) {
callback->Run(reporter);
}
LOG(INFO) << "FakeStatsPlugin[" << this << "]::TriggerCallbacks(): END";
VLOG(2) << "FakeStatsPlugin[" << this << "]::TriggerCallbacks(): END";
}
absl::optional<int64_t> GetInt64CallbackGaugeValue(
GlobalInstrumentsRegistry::GlobalInstrumentHandle handle,
@ -467,12 +463,12 @@ class FakeStatsPlugin : public StatsPlugin {
GlobalInstrumentsRegistry::GlobalInstrumentHandle handle, int64_t value,
absl::Span<const absl::string_view> label_values,
absl::Span<const absl::string_view> optional_values) override {
LOG(INFO) << "FakeStatsPlugin[" << this
<< "]::Reporter::Report(index=" << handle.index
<< ", value=(int64_t)" << value << ", label_values={"
<< absl::StrJoin(label_values, ", ")
<< "}, optional_label_values={"
<< absl::StrJoin(optional_values, ", ") << "}";
VLOG(2) << "FakeStatsPlugin[" << this
<< "]::Reporter::Report(index=" << handle.index
<< ", value=(int64_t)" << value << ", label_values={"
<< absl::StrJoin(label_values, ", ")
<< "}, optional_label_values={"
<< absl::StrJoin(optional_values, ", ") << "}";
MutexLock lock(&plugin_.callback_mu_);
auto iter = plugin_.int64_callback_gauges_.find(handle.index);
if (iter == plugin_.int64_callback_gauges_.end()) return;
@ -483,12 +479,12 @@ class FakeStatsPlugin : public StatsPlugin {
GlobalInstrumentsRegistry::GlobalInstrumentHandle handle, double value,
absl::Span<const absl::string_view> label_values,
absl::Span<const absl::string_view> optional_values) override {
LOG(INFO) << "FakeStatsPlugin[" << this
<< "]::Reporter::Report(index=" << handle.index
<< ", value=(double)" << value << ", label_values={"
<< absl::StrJoin(label_values, ", ")
<< "}, optional_label_values={"
<< absl::StrJoin(optional_values, ", ") << "}";
VLOG(2) << "FakeStatsPlugin[" << this
<< "]::Reporter::Report(index=" << handle.index
<< ", value=(double)" << value << ", label_values={"
<< absl::StrJoin(label_values, ", ")
<< "}, optional_label_values={"
<< absl::StrJoin(optional_values, ", ") << "}";
MutexLock lock(&plugin_.callback_mu_);
auto iter = plugin_.double_callback_gauges_.find(handle.index);
if (iter == plugin_.double_callback_gauges_.end()) return;

80
test/cpp/microbenchmarks/bm_stats_plugin.cc
Unescape View File

@ -32,12 +32,22 @@
namespace {
constexpr const absl::string_view kMetricName = "test.counter";
constexpr const absl::string_view kMetricNameWithLabels =
"test.counter_with_labels";
const auto kCounterHandle =
grpc_core::GlobalInstrumentsRegistry::RegisterUInt64Counter(
kMetricName, "A simple test counter", "{count}", true)
.Build();
const auto kCounterWithLabelsHandle =
grpc_core::GlobalInstrumentsRegistry::RegisterUInt64Counter(
kMetricNameWithLabels, "A simple test counter with labels", "{count}",
true)
.Labels("key1", "key2", "key3")
.OptionalLabels("opt_key1", "opt_key2", "opt_key3")
.Build();
void BM_AddCounterWithFakeStatsPlugin(benchmark::State& state) {
grpc_core::GlobalStatsPluginRegistryTestPeer::
ResetGlobalStatsPluginRegistry();
@ -53,6 +63,23 @@ void BM_AddCounterWithFakeStatsPlugin(benchmark::State& state) {
}
BENCHMARK(BM_AddCounterWithFakeStatsPlugin);
void BM_AddCounterWithLabelsWithFakeStatsPlugin(benchmark::State& state) {
grpc_core::GlobalStatsPluginRegistryTestPeer::
ResetGlobalStatsPluginRegistry();
grpc_core::FakeStatsPluginBuilder().BuildAndRegister();
grpc_event_engine::experimental::ChannelArgsEndpointConfig endpoint_config;
auto stats_plugin_group =
grpc_core::GlobalStatsPluginRegistry::GetStatsPluginsForChannel(
grpc_core::experimental::StatsPluginChannelScope("", "",
endpoint_config));
for (auto _ : state) {
stats_plugin_group.AddCounter(kCounterWithLabelsHandle, 1,
{"val1", "val2", "val3"},
{"opt_val1", "opt_val2", "opt_val3"});
}
}
BENCHMARK(BM_AddCounterWithLabelsWithFakeStatsPlugin);
void BM_AddCounterWithOTelPlugin(benchmark::State& state) {
grpc_core::GlobalStatsPluginRegistryTestPeer::
ResetGlobalStatsPluginRegistry();
@ -74,6 +101,59 @@ void BM_AddCounterWithOTelPlugin(benchmark::State& state) {
}
BENCHMARK(BM_AddCounterWithOTelPlugin);
void BM_AddCounterWithLabelsWithOTelPlugin(benchmark::State& state) {
grpc_core::GlobalStatsPluginRegistryTestPeer::
ResetGlobalStatsPluginRegistry();
auto meter_provider =
std::make_shared<opentelemetry::sdk::metrics::MeterProvider>();
auto status = grpc::OpenTelemetryPluginBuilder()
.EnableMetrics({kMetricName})
.SetMeterProvider(std::move(meter_provider))
.BuildAndRegisterGlobal();
CHECK(status.ok());
grpc_event_engine::experimental::ChannelArgsEndpointConfig endpoint_config;
auto stats_plugin_group =
grpc_core::GlobalStatsPluginRegistry::GetStatsPluginsForChannel(
grpc_core::experimental::StatsPluginChannelScope("", "",
endpoint_config));
for (auto _ : state) {
stats_plugin_group.AddCounter(kCounterWithLabelsHandle, 1,
{"val1", "val2", "val3"},
{"opt_val1", "opt_val2", "opt_val3"});
}
}
BENCHMARK(BM_AddCounterWithLabelsWithOTelPlugin);
void BM_AddCounterWithNoPlugin(benchmark::State& state) {
grpc_core::GlobalStatsPluginRegistryTestPeer::
ResetGlobalStatsPluginRegistry();
grpc_event_engine::experimental::ChannelArgsEndpointConfig endpoint_config;
auto stats_plugin_group =
grpc_core::GlobalStatsPluginRegistry::GetStatsPluginsForChannel(
grpc_core::experimental::StatsPluginChannelScope("", "",
endpoint_config));
for (auto _ : state) {
stats_plugin_group.AddCounter(kCounterHandle, 1, {}, {});
}
}
BENCHMARK(BM_AddCounterWithNoPlugin);
void BM_AddCounterWithLabelsWithNoPlugin(benchmark::State& state) {
grpc_core::GlobalStatsPluginRegistryTestPeer::
ResetGlobalStatsPluginRegistry();
grpc_event_engine::experimental::ChannelArgsEndpointConfig endpoint_config;
auto stats_plugin_group =
grpc_core::GlobalStatsPluginRegistry::GetStatsPluginsForChannel(
grpc_core::experimental::StatsPluginChannelScope("", "",
endpoint_config));
for (auto _ : state) {
stats_plugin_group.AddCounter(kCounterWithLabelsHandle, 1,
{"val1", "val2", "val3"},
{"opt_val1", "opt_val2", "opt_val3"});
}
}
BENCHMARK(BM_AddCounterWithLabelsWithNoPlugin);
} // namespace
// Some distros have RunSpecifiedBenchmarks under the benchmark namespace,

Write Preview
Loading…
Cancel
Save