From 6822d9a7792c160265f05fd9f497c79bbe850822 Mon Sep 17 00:00:00 2001 From: Jan Tattermusch Date: Mon, 16 Sep 2019 18:14:51 +0200 Subject: [PATCH 1/2] correctly generate tests for bazel tests that dont use polling --- bazel/grpc_build_system.bzl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bazel/grpc_build_system.bzl b/bazel/grpc_build_system.bzl index afff5438808..5bf04f2ff0b 100644 --- a/bazel/grpc_build_system.bzl +++ b/bazel/grpc_build_system.bzl @@ -212,7 +212,7 @@ def grpc_cc_test(name, srcs = [], deps = [], external_deps = [], args = [], data exec_compatible_with = exec_compatible_with, ) else: - native.cc_test(tags = tags, **args) + native.cc_test(name = name, tags = tags, **args) ios_cc_test( name = name, tags = tags, From 6ebc1c616fd06192fff5433d260b8bb4551e1c07 Mon Sep 17 00:00:00 2001 From: Jan Tattermusch Date: Mon, 16 Sep 2019 18:15:45 +0200 Subject: [PATCH 2/2] set uses_polling=False for some bazel tests --- test/core/avl/BUILD | 1 + test/core/backoff/BUILD | 1 + test/core/channel/BUILD | 5 +++++ test/core/client_channel/BUILD | 2 ++ test/core/compression/BUILD | 4 ++++ test/core/debug/BUILD | 1 + test/core/end2end/BUILD | 1 + test/core/gpr/BUILD | 12 ++++++++++++ test/core/gprpp/BUILD | 9 +++++++++ test/core/http/BUILD | 1 + test/core/iomgr/BUILD | 7 +++++++ test/core/json/BUILD | 3 +++ test/core/memory_usage/BUILD | 1 + test/core/security/BUILD | 3 +++ test/core/slice/BUILD | 7 +++++++ test/core/surface/BUILD | 2 ++ test/core/transport/BUILD | 6 ++++++ test/core/transport/chttp2/BUILD | 7 +++++++ test/core/util/BUILD | 2 ++ test/cpp/codegen/BUILD | 3 +++ test/cpp/common/BUILD | 3 +++ test/cpp/qps/BUILD | 1 + test/cpp/util/BUILD | 4 ++++ 23 files changed, 86 insertions(+) diff --git a/test/core/avl/BUILD b/test/core/avl/BUILD index c31abebcbe5..861b96a9a62 100644 --- a/test/core/avl/BUILD +++ b/test/core/avl/BUILD @@ -27,4 +27,5 @@ grpc_cc_test( "//:grpc", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) diff --git a/test/core/backoff/BUILD b/test/core/backoff/BUILD index e4fc2871054..5c62ee8dadf 100644 --- a/test/core/backoff/BUILD +++ b/test/core/backoff/BUILD @@ -35,4 +35,5 @@ grpc_cc_test( "//:grpc", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) diff --git a/test/core/channel/BUILD b/test/core/channel/BUILD index 3249a16edda..e38c4c9c194 100644 --- a/test/core/channel/BUILD +++ b/test/core/channel/BUILD @@ -27,6 +27,7 @@ grpc_cc_test( "//:grpc", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) grpc_cc_test( @@ -38,6 +39,7 @@ grpc_cc_test( "//:grpc", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) grpc_cc_test( @@ -60,6 +62,7 @@ grpc_cc_test( "//:grpc", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) grpc_cc_test( @@ -107,6 +110,7 @@ grpc_cc_test( "//:grpc++", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) grpc_cc_test( @@ -120,4 +124,5 @@ grpc_cc_test( "//:grpc", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) diff --git a/test/core/client_channel/BUILD b/test/core/client_channel/BUILD index a9cfa961ec2..cafd6101ffc 100644 --- a/test/core/client_channel/BUILD +++ b/test/core/client_channel/BUILD @@ -53,6 +53,7 @@ grpc_cc_test( "//test/core/util:grpc_test_util", ], tags = ["no_windows"], + uses_polling = False, ) grpc_cc_test( @@ -78,6 +79,7 @@ grpc_cc_test( "//:grpc", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) grpc_cc_test( diff --git a/test/core/compression/BUILD b/test/core/compression/BUILD index 03c82689a85..9faeeef5078 100644 --- a/test/core/compression/BUILD +++ b/test/core/compression/BUILD @@ -27,6 +27,7 @@ grpc_cc_test( "//:grpc", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) grpc_cc_test( @@ -38,6 +39,7 @@ grpc_cc_test( "//:grpc", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) grpc_cc_test( @@ -49,6 +51,7 @@ grpc_cc_test( "//:grpc", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) grpc_cc_test( @@ -60,4 +63,5 @@ grpc_cc_test( "//:grpc", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) diff --git a/test/core/debug/BUILD b/test/core/debug/BUILD index c4209296702..2038d8d677a 100644 --- a/test/core/debug/BUILD +++ b/test/core/debug/BUILD @@ -30,4 +30,5 @@ grpc_cc_test( "//:grpc", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) diff --git a/test/core/end2end/BUILD b/test/core/end2end/BUILD index 16f987e847d..d13894050ff 100644 --- a/test/core/end2end/BUILD +++ b/test/core/end2end/BUILD @@ -141,6 +141,7 @@ grpc_cc_test( "//:grpc", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) grpc_cc_test( diff --git a/test/core/gpr/BUILD b/test/core/gpr/BUILD index c4ee5e977ad..04fd72ab486 100644 --- a/test/core/gpr/BUILD +++ b/test/core/gpr/BUILD @@ -26,6 +26,7 @@ grpc_cc_test( "//:gpr", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) grpc_cc_test( @@ -36,6 +37,7 @@ grpc_cc_test( "//:gpr", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) grpc_cc_test( @@ -46,6 +48,7 @@ grpc_cc_test( "//:gpr", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) grpc_cc_test( @@ -56,6 +59,7 @@ grpc_cc_test( "//:gpr", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) grpc_cc_test( @@ -66,6 +70,7 @@ grpc_cc_test( "//:gpr", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) grpc_cc_test( @@ -76,6 +81,7 @@ grpc_cc_test( "//:gpr", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) grpc_cc_test( @@ -86,6 +92,7 @@ grpc_cc_test( "//:gpr", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) grpc_cc_test( @@ -96,6 +103,7 @@ grpc_cc_test( "//:gpr", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) grpc_cc_test( @@ -106,6 +114,7 @@ grpc_cc_test( "//:gpr", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) grpc_cc_test( @@ -116,6 +125,7 @@ grpc_cc_test( "//:gpr", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) grpc_cc_test( @@ -126,6 +136,7 @@ grpc_cc_test( "//:gpr", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) grpc_cc_test( @@ -136,4 +147,5 @@ grpc_cc_test( "//:gpr", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) diff --git a/test/core/gprpp/BUILD b/test/core/gprpp/BUILD index 142fcbb571b..0b0236334b2 100644 --- a/test/core/gprpp/BUILD +++ b/test/core/gprpp/BUILD @@ -26,6 +26,7 @@ grpc_cc_test( "//:gpr", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) grpc_cc_test( @@ -39,6 +40,7 @@ grpc_cc_test( "//:gpr", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) grpc_cc_test( @@ -52,6 +54,7 @@ grpc_cc_test( "//:gpr", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) grpc_cc_test( @@ -62,6 +65,7 @@ grpc_cc_test( "//:gpr", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) grpc_cc_test( @@ -72,6 +76,7 @@ grpc_cc_test( "//:gpr", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) grpc_cc_test( @@ -85,6 +90,7 @@ grpc_cc_test( "//:gpr_base", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) grpc_cc_test( @@ -98,6 +104,7 @@ grpc_cc_test( "//:gpr_base", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) grpc_cc_test( @@ -122,6 +129,7 @@ grpc_cc_test( "//:gpr", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) grpc_cc_test( @@ -198,4 +206,5 @@ grpc_cc_test( "//:gpr", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) diff --git a/test/core/http/BUILD b/test/core/http/BUILD index 3e679262555..8951d1aba2e 100644 --- a/test/core/http/BUILD +++ b/test/core/http/BUILD @@ -109,6 +109,7 @@ grpc_cc_test( "//test/core/end2end:ssl_test_data", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) grpc_cc_test( diff --git a/test/core/iomgr/BUILD b/test/core/iomgr/BUILD index 808a635b80a..7e4cdc0d729 100644 --- a/test/core/iomgr/BUILD +++ b/test/core/iomgr/BUILD @@ -70,6 +70,7 @@ grpc_cc_test( "//:grpc", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) grpc_cc_test( @@ -128,6 +129,7 @@ grpc_cc_test( "//:grpc", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) grpc_cc_test( @@ -139,6 +141,7 @@ grpc_cc_test( "//:grpc", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) grpc_cc_test( @@ -290,6 +293,7 @@ grpc_cc_test( "//:grpc", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) grpc_cc_test( @@ -301,6 +305,7 @@ grpc_cc_test( "//:grpc", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) grpc_cc_test( @@ -312,6 +317,7 @@ grpc_cc_test( "//:grpc", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) grpc_cc_test( @@ -323,6 +329,7 @@ grpc_cc_test( "//:grpc", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) grpc_cc_test( diff --git a/test/core/json/BUILD b/test/core/json/BUILD index 5684505cbc9..c9298e5f2c4 100644 --- a/test/core/json/BUILD +++ b/test/core/json/BUILD @@ -59,6 +59,7 @@ grpc_cc_test( "//:grpc", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) grpc_cc_test( @@ -70,6 +71,7 @@ grpc_cc_test( "//:grpc", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) grpc_cc_test( @@ -81,4 +83,5 @@ grpc_cc_test( "//:grpc", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) diff --git a/test/core/memory_usage/BUILD b/test/core/memory_usage/BUILD index 38b088c75c7..c9da6b4241b 100644 --- a/test/core/memory_usage/BUILD +++ b/test/core/memory_usage/BUILD @@ -54,4 +54,5 @@ grpc_cc_test( "//:grpc", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) diff --git a/test/core/security/BUILD b/test/core/security/BUILD index b6d43c62722..c6dbc5fbed8 100644 --- a/test/core/security/BUILD +++ b/test/core/security/BUILD @@ -63,6 +63,7 @@ grpc_cc_test( "//:grpc", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) grpc_cc_test( @@ -98,6 +99,7 @@ grpc_cc_test( "//:grpc", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) grpc_cc_test( @@ -109,6 +111,7 @@ grpc_cc_test( "//:grpc", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) grpc_cc_test( diff --git a/test/core/slice/BUILD b/test/core/slice/BUILD index 12ee42ba9c3..dbca3477131 100644 --- a/test/core/slice/BUILD +++ b/test/core/slice/BUILD @@ -53,6 +53,7 @@ grpc_cc_test( "//:grpc", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) grpc_cc_test( @@ -64,6 +65,7 @@ grpc_cc_test( "//:grpc", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) grpc_cc_test( @@ -75,6 +77,7 @@ grpc_cc_test( "//:grpc", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) grpc_cc_test( @@ -86,6 +89,7 @@ grpc_cc_test( "//:grpc", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) grpc_cc_test( @@ -100,6 +104,7 @@ grpc_cc_test( "//:grpc", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) grpc_cc_test( @@ -114,6 +119,7 @@ grpc_cc_test( "//:grpc", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) grpc_cc_test( @@ -125,4 +131,5 @@ grpc_cc_test( "//:grpc", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) diff --git a/test/core/surface/BUILD b/test/core/surface/BUILD index 34777806cf2..fe6320babcf 100644 --- a/test/core/surface/BUILD +++ b/test/core/surface/BUILD @@ -27,6 +27,7 @@ grpc_cc_test( "//:grpc", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) grpc_cc_test( @@ -82,6 +83,7 @@ grpc_cc_test( "//:grpc", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) grpc_cc_test( diff --git a/test/core/transport/BUILD b/test/core/transport/BUILD index 44e4fcb978e..94ebb602d80 100644 --- a/test/core/transport/BUILD +++ b/test/core/transport/BUILD @@ -30,6 +30,7 @@ grpc_cc_test( "//:grpc", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) grpc_cc_test( @@ -44,6 +45,7 @@ grpc_cc_test( "//:grpc", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) grpc_cc_test( @@ -105,6 +107,7 @@ grpc_cc_test( "//:grpc", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) grpc_cc_test( @@ -116,6 +119,7 @@ grpc_cc_test( "//:grpc", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) grpc_cc_test( @@ -127,6 +131,7 @@ grpc_cc_test( "//:grpc", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) grpc_cc_test( @@ -140,4 +145,5 @@ grpc_cc_test( "//:grpc", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) diff --git a/test/core/transport/chttp2/BUILD b/test/core/transport/chttp2/BUILD index e5c1a7cff70..f31ba248d19 100644 --- a/test/core/transport/chttp2/BUILD +++ b/test/core/transport/chttp2/BUILD @@ -50,6 +50,7 @@ grpc_cc_test( "//:grpc", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) grpc_cc_test( @@ -61,6 +62,7 @@ grpc_cc_test( "//:grpc", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) grpc_cc_test( @@ -75,6 +77,7 @@ grpc_cc_test( "//:grpc", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) grpc_cc_test( @@ -86,6 +89,7 @@ grpc_cc_test( "//:grpc", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) grpc_cc_test( @@ -97,6 +101,7 @@ grpc_cc_test( "//:grpc", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) grpc_cc_test( @@ -108,6 +113,7 @@ grpc_cc_test( "//:grpc", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) grpc_cc_test( @@ -144,4 +150,5 @@ grpc_cc_test( "//:grpc", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) diff --git a/test/core/util/BUILD b/test/core/util/BUILD index 47f814a7ad3..3cf1fa3ecff 100644 --- a/test/core/util/BUILD +++ b/test/core/util/BUILD @@ -119,6 +119,7 @@ grpc_cc_test( ":grpc_test_util", "//:gpr", ], + uses_polling = False, ) grpc_cc_library( @@ -145,6 +146,7 @@ grpc_cc_test( ":grpc_test_util", "//:gpr", ], + uses_polling = False, ) sh_library( diff --git a/test/cpp/codegen/BUILD b/test/cpp/codegen/BUILD index 90af67bd858..69d5859489f 100644 --- a/test/cpp/codegen/BUILD +++ b/test/cpp/codegen/BUILD @@ -28,6 +28,7 @@ grpc_cc_test( "//:grpc++", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) grpc_cc_test( @@ -40,6 +41,7 @@ grpc_cc_test( "//:grpc++", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) grpc_cc_test( @@ -53,6 +55,7 @@ grpc_cc_test( "//:grpc++", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) grpc_cc_binary( diff --git a/test/cpp/common/BUILD b/test/cpp/common/BUILD index c31eb10344e..ac82acc073e 100644 --- a/test/cpp/common/BUILD +++ b/test/cpp/common/BUILD @@ -66,6 +66,7 @@ grpc_cc_test( "//test/core/util:grpc_test_util", "//test/cpp/util:test_util", ], + uses_polling = False, ) grpc_cc_test( @@ -78,6 +79,7 @@ grpc_cc_test( "//:grpc++", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) grpc_cc_test( @@ -90,6 +92,7 @@ grpc_cc_test( "//:grpc++", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) grpc_cc_test( diff --git a/test/cpp/qps/BUILD b/test/cpp/qps/BUILD index 8855a1c155d..5c84d75dc5f 100644 --- a/test/cpp/qps/BUILD +++ b/test/cpp/qps/BUILD @@ -163,6 +163,7 @@ grpc_cc_test( ":interarrival", "//test/cpp/util:test_config", ], + uses_polling = False, ) grpc_cc_test( diff --git a/test/cpp/util/BUILD b/test/cpp/util/BUILD index 858b88eb01b..2e9d1cc8bba 100644 --- a/test/cpp/util/BUILD +++ b/test/cpp/util/BUILD @@ -213,6 +213,7 @@ grpc_cc_test( deps = [ ":test_util", ], + uses_polling = False, ) grpc_cc_test( @@ -226,6 +227,7 @@ grpc_cc_test( deps = [ ":test_util", ], + uses_polling = False, ) grpc_cc_test( @@ -240,6 +242,7 @@ grpc_cc_test( "//:grpc++", "//test/core/util:grpc_test_util", ], + uses_polling = False, ) grpc_cc_test( @@ -253,6 +256,7 @@ grpc_cc_test( deps = [ ":test_util", ], + uses_polling = False, ) grpc_cc_test(