From 24683f12855cd93917e531fe5cd528e366dc43d2 Mon Sep 17 00:00:00 2001 From: Yash Tibrewal Date: Tue, 23 Jul 2024 11:51:08 -0700 Subject: [PATCH] [log] Reducing log spam (#37253) This PR changes many of the `LOG(INFO)` statements that are not guarded by TraceFlags to either be - * guarded by a TraceFlag * logged under `VLOG(2)` Closes #37253 COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/37253 from yashykt:LoggingLevelFix 50d332e17ac1280cab8feaa16fec2080f21b9fc3 PiperOrigin-RevId: 655248697 --- .../chttp2/transport/chttp2_transport.cc | 99 ++++++++++--------- .../http_connect/http_proxy_mapper.cc | 15 ++- src/core/lib/compression/message_compress.cc | 6 +- .../posix_engine/posix_endpoint.cc | 6 +- .../posix_engine/posix_endpoint.h | 2 +- .../posix_engine_listener_utils.cc | 12 +-- .../posix_engine/tcp_socket_utils.cc | 11 ++- .../lib/event_engine/windows/win_socket.cc | 6 +- .../event_engine/windows/windows_endpoint.cc | 8 +- src/core/lib/iomgr/endpoint_pair_windows.cc | 8 +- src/core/lib/iomgr/socket_windows.cc | 6 +- src/core/lib/iomgr/tcp_posix.cc | 3 +- src/core/lib/iomgr/tcp_server_posix.cc | 17 ++-- src/core/lib/iomgr/tcp_server_windows.cc | 4 +- src/core/lib/promise/party.cc | 7 +- src/core/load_balancing/grpclb/grpclb.cc | 25 ++--- src/core/util/subprocess_windows.cc | 2 +- src/cpp/server/server_builder.cc | 12 +-- 18 files changed, 131 insertions(+), 118 deletions(-) diff --git a/src/core/ext/transport/chttp2/transport/chttp2_transport.cc b/src/core/ext/transport/chttp2/transport/chttp2_transport.cc index 3a5c6ea7544..2d49792ba21 100644 --- a/src/core/ext/transport/chttp2/transport/chttp2_transport.cc +++ b/src/core/ext/transport/chttp2/transport/chttp2_transport.cc @@ -1760,62 +1760,65 @@ void grpc_chttp2_ack_ping(grpc_chttp2_transport* t, uint64_t id) { void grpc_chttp2_keepalive_timeout( grpc_core::RefCountedPtr t) { - t->combiner->Run(grpc_core::NewClosure([t](grpc_error_handle) { - LOG(INFO) << t->peer_string.as_string_view() - << ": Keepalive timeout. Closing transport."; - send_goaway(t.get(), - grpc_error_set_int( - GRPC_ERROR_CREATE("keepalive_timeout"), - grpc_core::StatusIntProperty::kHttp2Error, - GRPC_HTTP2_ENHANCE_YOUR_CALM), - /*immediate_disconnect_hint=*/true); - close_transport_locked( - t.get(), grpc_error_set_int( - GRPC_ERROR_CREATE("keepalive timeout"), - grpc_core::StatusIntProperty::kRpcStatus, - GRPC_STATUS_UNAVAILABLE)); - }), - absl::OkStatus()); + t->combiner->Run( + grpc_core::NewClosure([t](grpc_error_handle) { + GRPC_TRACE_LOG(http, INFO) << t->peer_string.as_string_view() + << ": Keepalive timeout. Closing transport."; + send_goaway( + t.get(), + grpc_error_set_int(GRPC_ERROR_CREATE("keepalive_timeout"), + grpc_core::StatusIntProperty::kHttp2Error, + GRPC_HTTP2_ENHANCE_YOUR_CALM), + /*immediate_disconnect_hint=*/true); + close_transport_locked( + t.get(), + grpc_error_set_int(GRPC_ERROR_CREATE("keepalive timeout"), + grpc_core::StatusIntProperty::kRpcStatus, + GRPC_STATUS_UNAVAILABLE)); + }), + absl::OkStatus()); } void grpc_chttp2_ping_timeout( grpc_core::RefCountedPtr t) { - t->combiner->Run(grpc_core::NewClosure([t](grpc_error_handle) { - LOG(INFO) << t->peer_string.as_string_view() - << ": Ping timeout. Closing transport."; - send_goaway(t.get(), - grpc_error_set_int( - GRPC_ERROR_CREATE("ping_timeout"), - grpc_core::StatusIntProperty::kHttp2Error, - GRPC_HTTP2_ENHANCE_YOUR_CALM), - /*immediate_disconnect_hint=*/true); - close_transport_locked( - t.get(), grpc_error_set_int( - GRPC_ERROR_CREATE("ping timeout"), - grpc_core::StatusIntProperty::kRpcStatus, - GRPC_STATUS_UNAVAILABLE)); - }), - absl::OkStatus()); + t->combiner->Run( + grpc_core::NewClosure([t](grpc_error_handle) { + GRPC_TRACE_LOG(http, INFO) << t->peer_string.as_string_view() + << ": Ping timeout. Closing transport."; + send_goaway( + t.get(), + grpc_error_set_int(GRPC_ERROR_CREATE("ping_timeout"), + grpc_core::StatusIntProperty::kHttp2Error, + GRPC_HTTP2_ENHANCE_YOUR_CALM), + /*immediate_disconnect_hint=*/true); + close_transport_locked( + t.get(), + grpc_error_set_int(GRPC_ERROR_CREATE("ping timeout"), + grpc_core::StatusIntProperty::kRpcStatus, + GRPC_STATUS_UNAVAILABLE)); + }), + absl::OkStatus()); } void grpc_chttp2_settings_timeout( grpc_core::RefCountedPtr t) { - t->combiner->Run(grpc_core::NewClosure([t](grpc_error_handle) { - LOG(INFO) << t->peer_string.as_string_view() - << ": Settings timeout. Closing transport."; - send_goaway(t.get(), - grpc_error_set_int( - GRPC_ERROR_CREATE("settings_timeout"), - grpc_core::StatusIntProperty::kHttp2Error, - GRPC_HTTP2_SETTINGS_TIMEOUT), - /*immediate_disconnect_hint=*/true); - close_transport_locked( - t.get(), grpc_error_set_int( - GRPC_ERROR_CREATE("settings timeout"), - grpc_core::StatusIntProperty::kRpcStatus, - GRPC_STATUS_UNAVAILABLE)); - }), - absl::OkStatus()); + t->combiner->Run( + grpc_core::NewClosure([t](grpc_error_handle) { + GRPC_TRACE_LOG(http, INFO) << t->peer_string.as_string_view() + << ": Settings timeout. Closing transport."; + send_goaway( + t.get(), + grpc_error_set_int(GRPC_ERROR_CREATE("settings_timeout"), + grpc_core::StatusIntProperty::kHttp2Error, + GRPC_HTTP2_SETTINGS_TIMEOUT), + /*immediate_disconnect_hint=*/true); + close_transport_locked( + t.get(), + grpc_error_set_int(GRPC_ERROR_CREATE("settings timeout"), + grpc_core::StatusIntProperty::kRpcStatus, + GRPC_STATUS_UNAVAILABLE)); + }), + absl::OkStatus()); } namespace { diff --git a/src/core/handshaker/http_connect/http_proxy_mapper.cc b/src/core/handshaker/http_connect/http_proxy_mapper.cc index 9de72aa1d92..93c8e2fe8eb 100644 --- a/src/core/handshaker/http_connect/http_proxy_mapper.cc +++ b/src/core/handshaker/http_connect/http_proxy_mapper.cc @@ -217,12 +217,11 @@ absl::optional HttpProxyMapper::MapName( return absl::nullopt; } if (uri->scheme() == "unix") { - LOG(INFO) << "not using proxy for Unix domain socket '" << server_uri - << "'"; + VLOG(2) << "not using proxy for Unix domain socket '" << server_uri << "'"; return absl::nullopt; } if (uri->scheme() == "vsock") { - LOG(INFO) << "not using proxy for VSock '" << server_uri << "'"; + VLOG(2) << "not using proxy for VSock '" << server_uri << "'"; return absl::nullopt; } // Prefer using 'no_grpc_proxy'. Fallback on 'no_proxy' if it is not set. @@ -235,17 +234,17 @@ absl::optional HttpProxyMapper::MapName( std::string server_port; if (!SplitHostPort(absl::StripPrefix(uri->path(), "/"), &server_host, &server_port)) { - LOG(INFO) << "unable to split host and port, not checking no_proxy list " - "for host '" - << server_uri << "'"; + VLOG(2) << "unable to split host and port, not checking no_proxy list " + "for host '" + << server_uri << "'"; } else { auto address = StringToSockaddr(server_host, 0); if (AddressIncluded(address.ok() ? absl::optional(*address) : absl::nullopt, server_host, *no_proxy_str)) { - LOG(INFO) << "not using proxy for host in no_proxy list '" << server_uri - << "'"; + VLOG(2) << "not using proxy for host in no_proxy list '" << server_uri + << "'"; return absl::nullopt; } } diff --git a/src/core/lib/compression/message_compress.cc b/src/core/lib/compression/message_compress.cc index e26369ad276..9fb7a7956ac 100644 --- a/src/core/lib/compression/message_compress.cc +++ b/src/core/lib/compression/message_compress.cc @@ -62,17 +62,17 @@ static int zlib_body(z_stream* zs, grpc_slice_buffer* input, } r = flate(zs, flush); if (r < 0 && r != Z_BUF_ERROR /* not fatal */) { - LOG(INFO) << "zlib error (" << r << ")"; + VLOG(2) << "zlib error (" << r << ")"; goto error; } } while (zs->avail_out == 0); if (zs->avail_in) { - LOG(INFO) << "zlib: not all input consumed"; + VLOG(2) << "zlib: not all input consumed"; goto error; } } if (r != Z_STREAM_END) { - LOG(INFO) << "zlib: Data error"; + VLOG(2) << "zlib: Data error"; goto error; } diff --git a/src/core/lib/event_engine/posix_engine/posix_endpoint.cc b/src/core/lib/event_engine/posix_engine/posix_endpoint.cc index b4c0c37688a..034149964e8 100644 --- a/src/core/lib/event_engine/posix_engine/posix_endpoint.cc +++ b/src/core/lib/event_engine/posix_engine/posix_endpoint.cc @@ -1297,9 +1297,9 @@ PosixEndpointImpl::PosixEndpointImpl(EventHandle* handle, } if (zerocopy_enabled) { - LOG(INFO) << "Tx-zero copy enabled for gRPC sends. RLIMIT_MEMLOCK value " - << "=" << GetRLimitMemLockMax() - << ",ulimit hard memlock value = " << GetUlimitHardMemLock(); + VLOG(2) << "Tx-zero copy enabled for gRPC sends. RLIMIT_MEMLOCK value " + << "=" << GetRLimitMemLockMax() + << ",ulimit hard memlock value = " << GetUlimitHardMemLock(); } } #endif // GRPC_LINUX_ERRQUEUE diff --git a/src/core/lib/event_engine/posix_engine/posix_endpoint.h b/src/core/lib/event_engine/posix_engine/posix_endpoint.h index 3e919857d28..0c42a5467c0 100644 --- a/src/core/lib/event_engine/posix_engine/posix_endpoint.h +++ b/src/core/lib/event_engine/posix_engine/posix_endpoint.h @@ -184,7 +184,7 @@ class TcpZerocopySendCtx { if (send_records_ == nullptr || free_send_records_ == nullptr) { gpr_free(send_records_); gpr_free(free_send_records_); - LOG(INFO) << "Disabling TCP TX zerocopy due to memory pressure.\n"; + VLOG(2) << "Disabling TCP TX zerocopy due to memory pressure.\n"; memory_limited_ = true; enabled_ = false; } else { diff --git a/src/core/lib/event_engine/posix_engine/posix_engine_listener_utils.cc b/src/core/lib/event_engine/posix_engine/posix_engine_listener_utils.cc index 0f47a261028..7aa624fc3cb 100644 --- a/src/core/lib/event_engine/posix_engine/posix_engine_listener_utils.cc +++ b/src/core/lib/event_engine/posix_engine/posix_engine_listener_utils.cc @@ -345,14 +345,14 @@ absl::StatusOr ListenerContainerAddWildcardAddresses( } if (assigned_port > 0) { if (!v6_sock.ok()) { - LOG(INFO) << "Failed to add :: listener, the environment may not support " - "IPv6: " - << v6_sock.status(); + VLOG(2) << "Failed to add :: listener, the environment may not support " + "IPv6: " + << v6_sock.status(); } if (!v4_sock.ok()) { - LOG(INFO) << "Failed to add 0.0.0.0 listener, " - "the environment may not support IPv4: " - << v4_sock.status(); + VLOG(2) << "Failed to add 0.0.0.0 listener, " + "the environment may not support IPv4: " + << v4_sock.status(); } return assigned_port; } else { diff --git a/src/core/lib/event_engine/posix_engine/tcp_socket_utils.cc b/src/core/lib/event_engine/posix_engine/tcp_socket_utils.cc index e9edb0b1b94..ae193ff2beb 100644 --- a/src/core/lib/event_engine/posix_engine/tcp_socket_utils.cc +++ b/src/core/lib/event_engine/posix_engine/tcp_socket_utils.cc @@ -636,8 +636,9 @@ void PosixSocketWrapper::TrySetSocketTcpUserTimeout( if (0 != getsockopt(fd_, IPPROTO_TCP, TCP_USER_TIMEOUT, &newval, &len)) { // This log is intentionally not protected behind a flag, so that users // know that TCP_USER_TIMEOUT is not being used. - LOG(INFO) << "TCP_USER_TIMEOUT is not available. TCP_USER_TIMEOUT " - "won't be used thereafter"; + GRPC_TRACE_LOG(tcp, INFO) + << "TCP_USER_TIMEOUT is not available. TCP_USER_TIMEOUT " + "won't be used thereafter"; g_socket_supports_tcp_user_timeout.store(-1); } else { GRPC_TRACE_LOG(tcp, INFO) @@ -691,7 +692,8 @@ bool PosixSocketWrapper::IsIpv6LoopbackAvailable() { int fd = socket(AF_INET6, SOCK_STREAM, 0); bool loopback_available = false; if (fd < 0) { - LOG(INFO) << "Disabling AF_INET6 sockets because socket() failed."; + GRPC_TRACE_LOG(tcp, INFO) + << "Disabling AF_INET6 sockets because socket() failed."; } else { sockaddr_in6 addr; memset(&addr, 0, sizeof(addr)); @@ -700,7 +702,8 @@ bool PosixSocketWrapper::IsIpv6LoopbackAvailable() { if (bind(fd, reinterpret_cast(&addr), sizeof(addr)) == 0) { loopback_available = true; } else { - LOG(INFO) << "Disabling AF_INET6 sockets because ::1 is not available."; + GRPC_TRACE_LOG(tcp, INFO) + << "Disabling AF_INET6 sockets because ::1 is not available."; } close(fd); } diff --git a/src/core/lib/event_engine/windows/win_socket.cc b/src/core/lib/event_engine/windows/win_socket.cc index ef1a0f0e46a..8c18b09ae42 100644 --- a/src/core/lib/event_engine/windows/win_socket.cc +++ b/src/core/lib/event_engine/windows/win_socket.cc @@ -71,7 +71,8 @@ void WinSocket::Shutdown() { &ioctl_num_bytes, NULL, NULL); if (status != 0) { char* utf8_message = gpr_format_message(WSAGetLastError()); - LOG(INFO) << "Unable to retrieve DisconnectEx pointer : " << utf8_message; + GRPC_TRACE_LOG(event_engine_endpoint, INFO) + << "Unable to retrieve DisconnectEx pointer : " << utf8_message; gpr_free(utf8_message); } else if (DisconnectEx(socket_, NULL, 0, 0) == FALSE) { auto last_error = WSAGetLastError(); @@ -79,7 +80,8 @@ void WinSocket::Shutdown() { // error, and log all others. if (last_error != WSAENOTCONN) { char* utf8_message = gpr_format_message(last_error); - LOG(INFO) << "DisconnectEx failed: " << utf8_message; + GRPC_TRACE_LOG(event_engine_endpoint, INFO) + << "DisconnectEx failed: " << utf8_message; gpr_free(utf8_message); } } diff --git a/src/core/lib/event_engine/windows/windows_endpoint.cc b/src/core/lib/event_engine/windows/windows_endpoint.cc index d991d04675d..d3bda779dd3 100644 --- a/src/core/lib/event_engine/windows/windows_endpoint.cc +++ b/src/core/lib/event_engine/windows/windows_endpoint.cc @@ -42,7 +42,8 @@ constexpr int kMaxWSABUFCount = 16; void DumpSliceBuffer(SliceBuffer* buffer, absl::string_view context_string) { for (size_t i = 0; i < buffer->Count(); i++) { auto str = buffer->MutableSliceAt(i).as_string_view(); - LOG(INFO) << context_string << ": " << str; + GRPC_TRACE_LOG(event_engine_endpoint, INFO) + << context_string << ": " << str; } } @@ -160,8 +161,9 @@ bool WindowsEndpoint::Write(absl::AnyInvocable on_writable, if (GRPC_TRACE_FLAG_ENABLED(event_engine_endpoint_data)) { for (size_t i = 0; i < data->Count(); i++) { auto str = data->RefSlice(i).as_string_view(); - LOG(INFO) << "WindowsEndpoint::" << this - << " WRITE (peer=" << peer_address_string_ << "): " << str; + GRPC_TRACE_LOG(event_engine_endpoint, INFO) + << "WindowsEndpoint::" << this + << " WRITE (peer=" << peer_address_string_ << "): " << str; } } CHECK(data->Count() <= UINT_MAX); diff --git a/src/core/lib/iomgr/endpoint_pair_windows.cc b/src/core/lib/iomgr/endpoint_pair_windows.cc index c238a6db71b..2fd37b4127e 100644 --- a/src/core/lib/iomgr/endpoint_pair_windows.cc +++ b/src/core/lib/iomgr/endpoint_pair_windows.cc @@ -66,13 +66,13 @@ static void create_sockets(SOCKET sv[2]) { closesocket(lst_sock); grpc_error_handle error = grpc_tcp_prepare_socket(cli_sock); if (!error.ok()) { - LOG(INFO) << "Prepare cli_sock failed with error: " - << grpc_core::StatusToString(error); + VLOG(2) << "Prepare cli_sock failed with error: " + << grpc_core::StatusToString(error); } error = grpc_tcp_prepare_socket(svr_sock); if (!error.ok()) { - LOG(INFO) << "Prepare svr_sock failed with error: " - << grpc_core::StatusToString(error); + VLOG(2) << "Prepare svr_sock failed with error: " + << grpc_core::StatusToString(error); } sv[1] = cli_sock; diff --git a/src/core/lib/iomgr/socket_windows.cc b/src/core/lib/iomgr/socket_windows.cc index 3bd40480ba5..e7a8b1e5fdd 100644 --- a/src/core/lib/iomgr/socket_windows.cc +++ b/src/core/lib/iomgr/socket_windows.cc @@ -132,7 +132,7 @@ void grpc_winsocket_shutdown(grpc_winsocket* winsocket) { DisconnectEx(winsocket->socket, NULL, 0, 0); } else { char* utf8_message = gpr_format_message(WSAGetLastError()); - LOG(INFO) << "Unable to retrieve DisconnectEx pointer : " << utf8_message; + VLOG(2) << "Unable to retrieve DisconnectEx pointer : " << utf8_message; gpr_free(utf8_message); } // Calling closesocket triggers invocation of any pending I/O operations with @@ -216,7 +216,7 @@ static void probe_ipv6_once(void) { SOCKET s = socket(AF_INET6, SOCK_STREAM, 0); g_ipv6_loopback_available = 0; if (s == INVALID_SOCKET) { - LOG(INFO) << "Disabling AF_INET6 sockets because socket() failed."; + VLOG(2) << "Disabling AF_INET6 sockets because socket() failed."; } else { grpc_sockaddr_in6 addr; memset(&addr, 0, sizeof(addr)); @@ -225,7 +225,7 @@ static void probe_ipv6_once(void) { if (bind(s, reinterpret_cast(&addr), sizeof(addr)) == 0) { g_ipv6_loopback_available = 1; } else { - LOG(INFO) << "Disabling AF_INET6 sockets because ::1 is not available."; + VLOG(2) << "Disabling AF_INET6 sockets because ::1 is not available."; } closesocket(s); } diff --git a/src/core/lib/iomgr/tcp_posix.cc b/src/core/lib/iomgr/tcp_posix.cc index 8882e943c09..f3ac9da0a3f 100644 --- a/src/core/lib/iomgr/tcp_posix.cc +++ b/src/core/lib/iomgr/tcp_posix.cc @@ -209,7 +209,8 @@ class TcpZerocopySendCtx { if (send_records_ == nullptr || free_send_records_ == nullptr) { gpr_free(send_records_); gpr_free(free_send_records_); - LOG(INFO) << "Disabling TCP TX zerocopy due to memory pressure.\n"; + GRPC_TRACE_LOG(tcp, INFO) + << "Disabling TCP TX zerocopy due to memory pressure.\n"; memory_limited_ = true; } else { for (int idx = 0; idx < max_sends_; ++idx) { diff --git a/src/core/lib/iomgr/tcp_server_posix.cc b/src/core/lib/iomgr/tcp_server_posix.cc index 832da72944b..14d5765489c 100644 --- a/src/core/lib/iomgr/tcp_server_posix.cc +++ b/src/core/lib/iomgr/tcp_server_posix.cc @@ -421,8 +421,9 @@ static void on_read(void* arg, grpc_error_handle err) { int64_t dropped_connections_count = num_dropped_connections.fetch_add(1, std::memory_order_relaxed) + 1; if (dropped_connections_count % 1000 == 1) { - LOG(INFO) << "Dropped >= " << dropped_connections_count - << " new connection attempts due to high memory pressure"; + GRPC_TRACE_LOG(tcp, INFO) + << "Dropped >= " << dropped_connections_count + << " new connection attempts due to high memory pressure"; } close(fd); continue; @@ -540,14 +541,14 @@ static grpc_error_handle add_wildcard_addrs_to_server(grpc_tcp_server* s, } if (*out_port > 0) { if (!v6_err.ok()) { - LOG(INFO) << "Failed to add :: listener, " - << "the environment may not support IPv6: " - << grpc_core::StatusToString(v6_err); + GRPC_TRACE_LOG(tcp, INFO) << "Failed to add :: listener, " + << "the environment may not support IPv6: " + << grpc_core::StatusToString(v6_err); } if (!v4_err.ok()) { - LOG(INFO) << "Failed to add 0.0.0.0 listener, " - << "the environment may not support IPv4: " - << grpc_core::StatusToString(v4_err); + GRPC_TRACE_LOG(tcp, INFO) << "Failed to add 0.0.0.0 listener, " + << "the environment may not support IPv4: " + << grpc_core::StatusToString(v4_err); } return absl::OkStatus(); } else { diff --git a/src/core/lib/iomgr/tcp_server_windows.cc b/src/core/lib/iomgr/tcp_server_windows.cc index 92b8a1f9a09..1e0bb260c46 100644 --- a/src/core/lib/iomgr/tcp_server_windows.cc +++ b/src/core/lib/iomgr/tcp_server_windows.cc @@ -386,8 +386,8 @@ static void on_accept(void* arg, grpc_error_handle error) { // this is necessary in the read/write case, it's useless for the accept // case. We only need to adjust the pending callback count if (!error.ok()) { - LOG(INFO) << "Skipping on_accept due to error: " - << grpc_core::StatusToString(error); + VLOG(2) << "Skipping on_accept due to error: " + << grpc_core::StatusToString(error); gpr_mu_unlock(&sp->server->mu); return; diff --git a/src/core/lib/promise/party.cc b/src/core/lib/promise/party.cc index aed03da625d..f1a9f70f772 100644 --- a/src/core/lib/promise/party.cc +++ b/src/core/lib/promise/party.cc @@ -302,12 +302,13 @@ bool Party::RunOneParticipant(int i) { currently_polling_ = kNotPolling; if (done) { if (!name.empty()) { - LOG(INFO) << DebugTag() << "[" << name << "] end poll and finish job " - << i; + GRPC_TRACE_LOG(promise_primitives, INFO) + << DebugTag() << "[" << name << "] end poll and finish job " << i; } participants_[i].store(nullptr, std::memory_order_relaxed); } else if (!name.empty()) { - LOG(INFO) << DebugTag() << "[" << name << "] end poll"; + GRPC_TRACE_LOG(promise_primitives, INFO) + << DebugTag() << "[" << name << "] end poll"; } return done; } diff --git a/src/core/load_balancing/grpclb/grpclb.cc b/src/core/load_balancing/grpclb/grpclb.cc index a39aa2d8c33..57eed1dcc63 100644 --- a/src/core/load_balancing/grpclb/grpclb.cc +++ b/src/core/load_balancing/grpclb/grpclb.cc @@ -496,9 +496,10 @@ class GrpcLb final : public LoadBalancingPolicy { new_state == GRPC_CHANNEL_TRANSIENT_FAILURE) { // In TRANSIENT_FAILURE. Cancel the fallback timer and go into // fallback mode immediately. - LOG(INFO) << "[grpclb " << parent_.get() - << "] balancer channel in state:TRANSIENT_FAILURE (" - << status.ToString() << "); entering fallback mode"; + GRPC_TRACE_LOG(glb, INFO) + << "[grpclb " << parent_.get() + << "] balancer channel in state:TRANSIENT_FAILURE (" + << status.ToString() << "); entering fallback mode"; parent_->fallback_at_startup_checks_pending_ = false; parent_->channel_control_helper()->GetEventEngine()->Cancel( *parent_->lb_fallback_timer_handle_); @@ -673,9 +674,10 @@ class GrpcLb::Serverlist::AddressIterator final server.load_balance_token, lb_token_length); if (lb_token.empty()) { auto addr_uri = grpc_sockaddr_to_uri(&addr); - LOG(INFO) << "Missing LB token for backend address '" - << (addr_uri.ok() ? *addr_uri : addr_uri.status().ToString()) - << "'. The empty token will be used instead"; + GRPC_TRACE_LOG(glb, INFO) + << "Missing LB token for backend address '" + << (addr_uri.ok() ? *addr_uri : addr_uri.status().ToString()) + << "'. The empty token will be used instead"; } // Return address with a channel arg containing LB token and stats object. callback(EndpointAddresses( @@ -850,11 +852,12 @@ void GrpcLb::Helper::UpdateState(grpc_connectivity_state state, client_stats = parent()->lb_calld_->client_stats()->Ref(); } if (GRPC_TRACE_FLAG_ENABLED(glb)) { - LOG(INFO) << "[grpclb " << parent() << " helper " << this - << "] state=" << ConnectivityStateName(state) << " (" - << status.ToString() << ") wrapping child picker " << picker.get() - << " (serverlist=" << serverlist.get() - << ", client_stats=" << client_stats.get() << ")"; + GRPC_TRACE_LOG(glb, INFO) + << "[grpclb " << parent() << " helper " << this + << "] state=" << ConnectivityStateName(state) << " (" + << status.ToString() << ") wrapping child picker " << picker.get() + << " (serverlist=" << serverlist.get() + << ", client_stats=" << client_stats.get() << ")"; } parent()->channel_control_helper()->UpdateState( state, status, diff --git a/src/core/util/subprocess_windows.cc b/src/core/util/subprocess_windows.cc index de45381f1fc..2824cb61071 100644 --- a/src/core/util/subprocess_windows.cc +++ b/src/core/util/subprocess_windows.cc @@ -114,7 +114,7 @@ void gpr_subprocess_interrupt(gpr_subprocess* p) { DWORD dwExitCode; if (GetExitCodeProcess(p->pi.hProcess, &dwExitCode)) { if (dwExitCode == STILL_ACTIVE) { - LOG(INFO) << "sending ctrl-break"; + VLOG(2) << "sending ctrl-break"; GenerateConsoleCtrlEvent(CTRL_BREAK_EVENT, p->pi.dwProcessId); p->joined = 1; p->interrupted = 1; diff --git a/src/cpp/server/server_builder.cc b/src/cpp/server/server_builder.cc index 708b2364897..b20aa88113c 100644 --- a/src/cpp/server/server_builder.cc +++ b/src/cpp/server/server_builder.cc @@ -389,16 +389,14 @@ std::unique_ptr ServerBuilder::BuildAndStart() { if (has_sync_methods) { // This is a Sync server - LOG(INFO) << "Synchronous server. Num CQs: " - << sync_server_settings_.num_cqs - << ", Min pollers: " << sync_server_settings_.min_pollers - << ", Max Pollers: " << sync_server_settings_.max_pollers - << ", CQ timeout (msec): " - << sync_server_settings_.cq_timeout_msec; + VLOG(2) << "Synchronous server. Num CQs: " << sync_server_settings_.num_cqs + << ", Min pollers: " << sync_server_settings_.min_pollers + << ", Max Pollers: " << sync_server_settings_.max_pollers + << ", CQ timeout (msec): " << sync_server_settings_.cq_timeout_msec; } if (has_callback_methods) { - LOG(INFO) << "Callback server."; + VLOG(2) << "Callback server."; } std::unique_ptr server(new grpc::Server(