From 234d3e22a011aa264faed30e3a25124ca953574a Mon Sep 17 00:00:00 2001 From: Craig Tiller Date: Thu, 10 Aug 2023 18:59:28 -0700 Subject: [PATCH] [promises] Fix flake noticed internally (#34038) Another case where we need to raise the 'failed before receive completed' flag prior to actually failing -- I think once promises are all rolled out I'd like to consider ways to remove this flag. --- src/core/lib/surface/call.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/src/core/lib/surface/call.cc b/src/core/lib/surface/call.cc index bb740d46a8e..d1ae791dfd7 100644 --- a/src/core/lib/surface/call.cc +++ b/src/core/lib/surface/call.cc @@ -3352,6 +3352,7 @@ void ServerPromiseBasedCall::CommitBatch(const grpc_op* ops, size_t nops, break; case GRPC_OP_RECV_MESSAGE: if (cancelled_.load(std::memory_order_relaxed)) { + set_failed_before_recv_message(); FailCompletion(completion); break; }