Adding comments about socket options portability

5 years ago · 2306e26130
parent 8391b12117
commit 2306e26130
1 changed files with 3 additions and 0 deletions
--- a/src/python/grpcio/grpc/_cython/_cygrpc/aio/iomgr/iomgr.pyx.pxi
+++ b/src/python/grpcio/grpc/_cython/_cygrpc/aio/iomgr/iomgr.pyx.pxi
@ -125,7 +125,10 @@ cdef grpc_error* asyncio_socket_listen(grpc_custom_socket* grpc_socket) with gil


 def _asyncio_apply_socket_options(object s, int flags):
+    # Turn SO_REUSEADDR on for TCP sockets; if we want to support UDS, we will
+    # need to update this function.
    s.setsockopt(native_socket.SOL_SOCKET, native_socket.SO_REUSEADDR, 1)
+    # SO_REUSEPORT only available in POSIX systems.
    if platform.system() != 'Windows':
        if GRPC_CUSTOM_SOCKET_OPT_SO_REUSEPORT & flags:
            s.setsockopt(native_socket.SOL_SOCKET, native_socket.SO_REUSEPORT, 1)