Merge pull request #16753 from jtattermusch/unify_fallthrough

Unify fallthrough comment in switch statements
pull/16837/head
Jan Tattermusch 6 years ago committed by GitHub
commit 223995b3de
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 2
      src/core/ext/filters/client_channel/lb_policy/grpclb/grpclb.cc
  2. 2
      src/core/lib/iomgr/timer_manager.cc
  3. 2
      test/core/iomgr/tcp_client_posix_test.cc
  4. 2
      test/core/iomgr/tcp_client_uv_test.cc

@ -1491,7 +1491,7 @@ void GrpcLb::OnBalancerChannelConnectivityChangedLocked(void* arg,
grpclb_policy->lb_call_backoff_.Reset(); grpclb_policy->lb_call_backoff_.Reset();
grpclb_policy->StartBalancerCallLocked(); grpclb_policy->StartBalancerCallLocked();
} }
// Fall through. // fallthrough
case GRPC_CHANNEL_SHUTDOWN: case GRPC_CHANNEL_SHUTDOWN:
done: done:
grpclb_policy->watching_lb_channel_ = false; grpclb_policy->watching_lb_channel_ = false;

@ -245,7 +245,7 @@ static void timer_main_loop() {
gpr_log(GPR_INFO, "timers not checked: expect another thread to"); gpr_log(GPR_INFO, "timers not checked: expect another thread to");
} }
next = GRPC_MILLIS_INF_FUTURE; next = GRPC_MILLIS_INF_FUTURE;
/* fall through */ // fallthrough
case GRPC_TIMERS_CHECKED_AND_EMPTY: case GRPC_TIMERS_CHECKED_AND_EMPTY:
if (!wait_until(next)) { if (!wait_until(next)) {
return; return;

@ -170,7 +170,7 @@ void test_fails(void) {
break; break;
case GRPC_TIMERS_NOT_CHECKED: case GRPC_TIMERS_NOT_CHECKED:
polling_deadline = 0; polling_deadline = 0;
/* fall through */ // fallthrough
case GRPC_TIMERS_CHECKED_AND_EMPTY: case GRPC_TIMERS_CHECKED_AND_EMPTY:
GPR_ASSERT(GRPC_LOG_IF_ERROR( GPR_ASSERT(GRPC_LOG_IF_ERROR(
"pollset_work", "pollset_work",

@ -165,7 +165,7 @@ void test_fails(void) {
break; break;
case GRPC_TIMERS_NOT_CHECKED: case GRPC_TIMERS_NOT_CHECKED:
polling_deadline = grpc_timespec_to_millis_round_up(now); polling_deadline = grpc_timespec_to_millis_round_up(now);
/* fall through */ // fallthrough
case GRPC_TIMERS_CHECKED_AND_EMPTY: case GRPC_TIMERS_CHECKED_AND_EMPTY:
GPR_ASSERT(GRPC_LOG_IF_ERROR( GPR_ASSERT(GRPC_LOG_IF_ERROR(
"pollset_work", "pollset_work",

Loading…
Cancel
Save