From 1fd45fcd01d20d51c8d76b0e9ef06529688e2d6b Mon Sep 17 00:00:00 2001 From: AJ Heller Date: Wed, 25 Oct 2023 10:38:50 -0700 Subject: [PATCH] [EventEngine] Disable Posix EventEngine Listener experiment (#34793) There are a small handful of failures: TSAN issue: * https://source.cloud.google.com/results/invocations/f82a4be1-a38e-4a19-b22f-295ed6f7d2d2/targets/%2F%2Ftest%2Fcore%2Fend2end:bad_server_response_test@poller%3Dpoll/log Flakes: * https://source.cloud.google.com/results/invocations/a11b04d8-e0d1-4175-a7a2-6e712b9bef9b/targets/%2F%2Ftest%2Fcore%2Fend2end:cancel_with_status_test@poller%3Depoll1/tests --- bazel/experiments.bzl | 10 ++++------ src/core/lib/experiments/experiments.cc | 2 +- src/core/lib/experiments/experiments.h | 3 +-- src/core/lib/experiments/rollouts.yaml | 2 +- 4 files changed, 7 insertions(+), 10 deletions(-) diff --git a/bazel/experiments.bzl b/bazel/experiments.bzl index 753a7955c66..ae93553dbcf 100644 --- a/bazel/experiments.bzl +++ b/bazel/experiments.bzl @@ -203,6 +203,7 @@ EXPERIMENTS = { ], "core_end2end_test": [ "event_engine_client", + "event_engine_listener", "promise_based_client_call", "promise_based_server_call", "work_serializer_dispatch", @@ -218,6 +219,9 @@ EXPERIMENTS = { "event_engine_client_test": [ "event_engine_client", ], + "event_engine_listener_test": [ + "event_engine_listener", + ], "flow_control_test": [ "multiping", "peer_state_based_framing", @@ -253,9 +257,6 @@ EXPERIMENTS = { "block_excessive_requests_before_settings_ack", "tarpit", ], - "core_end2end_test": [ - "event_engine_listener", - ], "cpp_end2end_test": [ "chttp2_batch_requests", "chttp2_offload_on_rst_stream", @@ -265,9 +266,6 @@ EXPERIMENTS = { "round_robin_delegate_to_pick_first", "wrr_delegate_to_pick_first", ], - "event_engine_listener_test": [ - "event_engine_listener", - ], "flow_control_test": [ "chttp2_batch_requests", "chttp2_offload_on_rst_stream", diff --git a/src/core/lib/experiments/experiments.cc b/src/core/lib/experiments/experiments.cc index 8f7ca123ebf..0a7a70fe7d1 100644 --- a/src/core/lib/experiments/experiments.cc +++ b/src/core/lib/experiments/experiments.cc @@ -799,7 +799,7 @@ const ExperimentMetadata g_experiment_metadata[] = { {"event_engine_dns", description_event_engine_dns, additional_constraints_event_engine_dns, false, false}, {"event_engine_listener", description_event_engine_listener, - additional_constraints_event_engine_listener, true, true}, + additional_constraints_event_engine_listener, false, true}, {"free_large_allocator", description_free_large_allocator, additional_constraints_free_large_allocator, false, true}, {"http2_stats_fix", description_http2_stats_fix, diff --git a/src/core/lib/experiments/experiments.h b/src/core/lib/experiments/experiments.h index f8d644ec6ac..3b6fbd31782 100644 --- a/src/core/lib/experiments/experiments.h +++ b/src/core/lib/experiments/experiments.h @@ -236,8 +236,7 @@ inline bool IsClientPrivacyEnabled() { return false; } inline bool IsCombinerOffloadToEventEngineEnabled() { return true; } inline bool IsEventEngineClientEnabled() { return false; } inline bool IsEventEngineDnsEnabled() { return false; } -#define GRPC_EXPERIMENT_IS_INCLUDED_EVENT_ENGINE_LISTENER -inline bool IsEventEngineListenerEnabled() { return true; } +inline bool IsEventEngineListenerEnabled() { return false; } inline bool IsFreeLargeAllocatorEnabled() { return false; } #define GRPC_EXPERIMENT_IS_INCLUDED_HTTP2_STATS_FIX inline bool IsHttp2StatsFixEnabled() { return true; } diff --git a/src/core/lib/experiments/rollouts.yaml b/src/core/lib/experiments/rollouts.yaml index 5aa0c8f6b34..ffc067fee6a 100644 --- a/src/core/lib/experiments/rollouts.yaml +++ b/src/core/lib/experiments/rollouts.yaml @@ -72,7 +72,7 @@ default: # not tested on iOS at all ios: broken - posix: true + posix: false windows: true - name: free_large_allocator default: false