[work-serializer] Enable `work_serializer_dispatch` everywhere (#38054)

Closes #38054

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/38054 from ctiller:burn-baby-burn 055de2f444
PiperOrigin-RevId: 694680573
pull/37928/merge
Craig Tiller 3 weeks ago committed by Copybara-Service
parent da58cffb04
commit 1be5e4eff9
  1. 14
      bazel/experiments.bzl
  2. 4
      src/core/lib/experiments/experiments.cc
  3. 6
      src/core/lib/experiments/experiments.h
  4. 7
      src/core/lib/experiments/rollouts.yaml

@ -84,6 +84,10 @@ EXPERIMENTS = {
"core_end2end_test": [
"event_engine_client",
"event_engine_listener",
"work_serializer_dispatch",
],
"cpp_end2end_test": [
"work_serializer_dispatch",
],
"cpp_lb_end2end_test": [
"pick_first_new",
@ -96,12 +100,14 @@ EXPERIMENTS = {
],
"lb_unit_test": [
"pick_first_new",
"work_serializer_dispatch",
],
"resolver_component_tests_runner_invoker": [
"event_engine_dns",
],
"xds_end2end_test": [
"pick_first_new",
"work_serializer_dispatch",
],
},
},
@ -129,14 +135,22 @@ EXPERIMENTS = {
],
},
"on": {
"core_end2end_test": [
"work_serializer_dispatch",
],
"cpp_end2end_test": [
"work_serializer_dispatch",
],
"cpp_lb_end2end_test": [
"pick_first_new",
],
"lb_unit_test": [
"pick_first_new",
"work_serializer_dispatch",
],
"xds_end2end_test": [
"pick_first_new",
"work_serializer_dispatch",
],
},
},

@ -197,7 +197,7 @@ const ExperimentMetadata g_experiment_metadata[] = {
additional_constraints_unconstrained_max_quota_buffer_size, nullptr, 0,
false, true},
{"work_serializer_dispatch", description_work_serializer_dispatch,
additional_constraints_work_serializer_dispatch, nullptr, 0, false, true},
additional_constraints_work_serializer_dispatch, nullptr, 0, true, true},
};
} // namespace grpc_core
@ -378,7 +378,7 @@ const ExperimentMetadata g_experiment_metadata[] = {
additional_constraints_unconstrained_max_quota_buffer_size, nullptr, 0,
false, true},
{"work_serializer_dispatch", description_work_serializer_dispatch,
additional_constraints_work_serializer_dispatch, nullptr, 0, false, true},
additional_constraints_work_serializer_dispatch, nullptr, 0, true, true},
};
} // namespace grpc_core

@ -90,7 +90,8 @@ inline bool IsTimeCachingInPartyEnabled() { return true; }
#define GRPC_EXPERIMENT_IS_INCLUDED_TRACE_RECORD_CALLOPS
inline bool IsTraceRecordCallopsEnabled() { return true; }
inline bool IsUnconstrainedMaxQuotaBufferSizeEnabled() { return false; }
inline bool IsWorkSerializerDispatchEnabled() { return false; }
#define GRPC_EXPERIMENT_IS_INCLUDED_WORK_SERIALIZER_DISPATCH
inline bool IsWorkSerializerDispatchEnabled() { return true; }
#elif defined(GPR_WINDOWS)
#define GRPC_EXPERIMENT_IS_INCLUDED_CALL_TRACER_IN_TRANSPORT
@ -129,7 +130,8 @@ inline bool IsTimeCachingInPartyEnabled() { return true; }
#define GRPC_EXPERIMENT_IS_INCLUDED_TRACE_RECORD_CALLOPS
inline bool IsTraceRecordCallopsEnabled() { return true; }
inline bool IsUnconstrainedMaxQuotaBufferSizeEnabled() { return false; }
inline bool IsWorkSerializerDispatchEnabled() { return false; }
#define GRPC_EXPERIMENT_IS_INCLUDED_WORK_SERIALIZER_DISPATCH
inline bool IsWorkSerializerDispatchEnabled() { return true; }
#else
#define GRPC_EXPERIMENT_IS_INCLUDED_CALL_TRACER_IN_TRANSPORT

@ -113,9 +113,4 @@
- name: work_serializer_clears_time_cache
default: true
- name: work_serializer_dispatch
default:
# TODO(ysseung): Not fully tested.
ios: broken
posix: true
# TODO(ysseung): Test flakes not fully resolved.
windows: broken
default: true

Loading…
Cancel
Save