From 1bab0019e54015524d2f041dbb857b9e631c0b16 Mon Sep 17 00:00:00 2001 From: yijiem Date: Thu, 18 Jul 2024 17:03:04 -0700 Subject: [PATCH] review --- src/core/lib/event_engine/ares_resolver.cc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/core/lib/event_engine/ares_resolver.cc b/src/core/lib/event_engine/ares_resolver.cc index 23e52779ab7..160933b99ee 100644 --- a/src/core/lib/event_engine/ares_resolver.cc +++ b/src/core/lib/event_engine/ares_resolver.cc @@ -84,8 +84,9 @@ namespace experimental { namespace { -// A rough limit on the number of records (A/AAAA or SRV) we may get from a -// single response. +// A hard limit on the number of records (A/AAAA or SRV) we may get from a +// single response. This is to be defensive to prevent a bad DNS response from +// OOMing the process. constexpr int kMaxRecordSize = 65536; absl::Status AresStatusToAbslStatus(int status, absl::string_view error_msg) {