review

8 months ago · 1bab0019e5
parent 5375f8f68b
commit 1bab0019e5
1 changed files with 3 additions and 2 deletions
--- a/src/core/lib/event_engine/ares_resolver.cc
+++ b/src/core/lib/event_engine/ares_resolver.cc
@ -84,8 +84,9 @@ namespace experimental {

 namespace {

-// A rough limit on the number of records (A/AAAA or SRV) we may get from a
-// single response.
+// A hard limit on the number of records (A/AAAA or SRV) we may get from a
+// single response. This is to be defensive to prevent a bad DNS response from
+// OOMing the process.
 constexpr int kMaxRecordSize = 65536;

 absl::Status AresStatusToAbslStatus(int status, absl::string_view error_msg) {