Merge pull request #17196 from AspirinSJL/revert_lb_update

Revert RR policy update in xDS
pull/17149/head
Juanli Shen 6 years ago committed by GitHub
commit 1a4286df98
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 6
      src/core/ext/filters/client_channel/lb_policy/xds/xds.cc

@ -1321,10 +1321,12 @@ void XdsLb::ProcessChannelArgsLocked(const grpc_channel_args& args) {
void XdsLb::UpdateLocked(const grpc_channel_args& args) { void XdsLb::UpdateLocked(const grpc_channel_args& args) {
ProcessChannelArgsLocked(args); ProcessChannelArgsLocked(args);
// Note: We have disabled fallback mode in the code, so we don't need to // Update the existing RR policy.
// handle fallback address changes. // Note: We have disabled fallback mode in the code, so this RR policy must
// have been created from a serverlist.
// TODO(vpowar): Handle the fallback_address changes when we add support for // TODO(vpowar): Handle the fallback_address changes when we add support for
// fallback in xDS. // fallback in xDS.
if (rr_policy_ != nullptr) CreateOrUpdateRoundRobinPolicyLocked();
// Start watching the LB channel connectivity for connection, if not // Start watching the LB channel connectivity for connection, if not
// already doing so. // already doing so.
if (!watching_lb_channel_) { if (!watching_lb_channel_) {

Loading…
Cancel
Save