Add explanation to the comments

reviewable/pr20597/r3
Na-Na Pang 5 years ago
parent 60f6689103
commit 1a374bc984
  1. 4
      src/proto/grpc/testing/control.proto
  2. 2
      test/cpp/qps/driver.cc

@ -220,7 +220,9 @@ message Scenarios {
// once the scenario has finished.
message ScenarioResultSummary
{
// Total number of queries per second over all clients.
// Total number of oeprations per second over all clients. What is counted as 1 'operation' depends on the benchmark scenarios:
// For unary benchmarks, an operation is processing of a single unary RPC.
// For streaming benchmarks, an operation is processing of a single ping pong of request and response.
double qps = 1;
// QPS per server core.
double qps_per_server_core = 2;

@ -148,7 +148,6 @@ static void postprocess_scenario_result(ScenarioResult* result) {
// all clients
double qps = 0;
double client_system_cpu_load = 0, client_user_cpu_load = 0;
double server_system_cpu_load = 0, server_user_cpu_load = 0;
for (size_t i = 0; i < result->client_stats_size(); i++) {
auto client_stat = result->client_stats(i);
qps += client_stat.latencies().count() / client_stat.time_elapsed();
@ -159,6 +158,7 @@ static void postprocess_scenario_result(ScenarioResult* result) {
}
// Calculate cpu load for each server and then aggregate results for all
// servers
double server_system_cpu_load = 0, server_user_cpu_load = 0;
for (size_t i = 0; i < result->server_stats_size(); i++) {
auto server_stat = result->server_stats(i);
server_system_cpu_load +=

Loading…
Cancel
Save