From fa6c944f4c53acd28aa1392f1d3e8045c1340029 Mon Sep 17 00:00:00 2001 From: HarrisonXi Date: Wed, 29 May 2019 18:39:30 +0800 Subject: [PATCH 1/2] remove notification observer to avoid iOS 8 crash --- src/objective-c/GRPCClient/GRPCCall.m | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/objective-c/GRPCClient/GRPCCall.m b/src/objective-c/GRPCClient/GRPCCall.m index 495f94289e7..ba91640269e 100644 --- a/src/objective-c/GRPCClient/GRPCCall.m +++ b/src/objective-c/GRPCClient/GRPCCall.m @@ -648,6 +648,8 @@ const char *kCFStreamVarName = "grpc_cfstream"; } - (void)dealloc { + [GRPCConnectivityMonitor unregisterObserver:self]; + __block GRPCWrappedCall *wrappedCall = _wrappedCall; dispatch_async(_callQueue, ^{ wrappedCall = nil; From 1259579a945ee442225bb79cbcf0ef01fd470d52 Mon Sep 17 00:00:00 2001 From: Muxi Yan Date: Thu, 30 May 2019 08:25:17 -0700 Subject: [PATCH 2/2] clang-format --- src/objective-c/GRPCClient/GRPCCall.m | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/objective-c/GRPCClient/GRPCCall.m b/src/objective-c/GRPCClient/GRPCCall.m index ba91640269e..52ba1356929 100644 --- a/src/objective-c/GRPCClient/GRPCCall.m +++ b/src/objective-c/GRPCClient/GRPCCall.m @@ -649,7 +649,7 @@ const char *kCFStreamVarName = "grpc_cfstream"; - (void)dealloc { [GRPCConnectivityMonitor unregisterObserver:self]; - + __block GRPCWrappedCall *wrappedCall = _wrappedCall; dispatch_async(_callQueue, ^{ wrappedCall = nil;