[transport] remove GetEndpoint() method (#36597)

Closes #36597

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36597 from markdroth:transport_endpoint_cleanup 6bd73e402e
PiperOrigin-RevId: 636714985
pull/36710/head
Mark D. Roth 9 months ago committed by Copybara-Service
parent 6c08d36c3b
commit 182f6885d3
  1. 5
      src/core/ext/transport/binder/transport/binder_transport.cc
  2. 1
      src/core/ext/transport/binder/transport/binder_transport.h
  3. 1
      src/core/ext/transport/chaotic_good/client_transport.h
  4. 3
      src/core/ext/transport/chaotic_good/server_transport.h
  5. 2
      src/core/ext/transport/chttp2/transport/chttp2_transport.cc
  6. 1
      src/core/ext/transport/chttp2/transport/internal.h
  7. 1
      src/core/ext/transport/cronet/transport/cronet_transport.cc
  8. 2
      src/core/ext/transport/inproc/inproc_transport.cc
  9. 3
      src/core/ext/transport/inproc/legacy_inproc_transport.cc
  10. 3
      src/core/lib/transport/transport.h
  11. 1
      test/core/channel/minimal_stack_is_minimal_test.cc
  12. 1
      test/core/server/xds_channel_stack_modifier_test.cc

@ -693,11 +693,6 @@ void grpc_binder_transport::Orphan() {
absl::OkStatus());
}
grpc_endpoint* grpc_binder_transport::GetEndpoint() {
gpr_log(GPR_INFO, __func__);
return nullptr;
}
size_t grpc_binder_transport::SizeOfStream() const {
return sizeof(grpc_binder_stream);
}

@ -60,7 +60,6 @@ struct grpc_binder_transport final : public grpc_core::FilterStackTransport {
void SetPollset(grpc_stream*, grpc_pollset*) override {}
void SetPollsetSet(grpc_stream*, grpc_pollset_set*) override {}
void PerformOp(grpc_transport_op* op) override;
grpc_endpoint* GetEndpoint() override;
size_t SizeOfStream() const override;
bool HackyDisableStreamOpBatchCoalescingInConnectedChannel() const override {
return false;

@ -82,7 +82,6 @@ class ChaoticGoodClientTransport final : public ClientTransport {
void SetPollset(grpc_stream*, grpc_pollset*) override {}
void SetPollsetSet(grpc_stream*, grpc_pollset_set*) override {}
void PerformOp(grpc_transport_op*) override;
grpc_endpoint* GetEndpoint() override { return nullptr; }
void Orphan() override {
AbortWithError();
Unref();

@ -94,7 +94,6 @@ class ChaoticGoodServerTransport final : public ServerTransport {
void SetPollset(grpc_stream*, grpc_pollset*) override {}
void SetPollsetSet(grpc_stream*, grpc_pollset_set*) override {}
void PerformOp(grpc_transport_op*) override;
grpc_endpoint* GetEndpoint() override { return nullptr; }
void Orphan() override;
void SetCallDestination(
@ -158,4 +157,4 @@ class ChaoticGoodServerTransport final : public ServerTransport {
} // namespace chaotic_good
} // namespace grpc_core
#endif // GRPC_SRC_CORE_EXT_TRANSPORT_CHAOTIC_GOOD_SERVER_TRANSPORT_H
#endif // GRPC_SRC_CORE_EXT_TRANSPORT_CHAOTIC_GOOD_SERVER_TRANSPORT_H

@ -3168,8 +3168,6 @@ const char* grpc_chttp2_initiate_write_reason_string(
GPR_UNREACHABLE_CODE(return "unknown");
}
grpc_endpoint* grpc_chttp2_transport::GetEndpoint() { return ep; }
size_t grpc_chttp2_transport::SizeOfStream() const {
return sizeof(grpc_chttp2_stream);
}

@ -256,7 +256,6 @@ struct grpc_chttp2_transport final : public grpc_core::FilterStackTransport,
void SetPollsetSet(grpc_stream* stream,
grpc_pollset_set* pollset_set) override;
void PerformOp(grpc_transport_op* op) override;
grpc_endpoint* GetEndpoint() override;
grpc_endpoint* ep;
grpc_core::Slice peer_string;

@ -131,7 +131,6 @@ struct grpc_cronet_transport final : public grpc_core::FilterStackTransport {
void SetPollsetSet(grpc_stream* /*stream*/,
grpc_pollset_set* /*pollset_set*/) override {}
void PerformOp(grpc_transport_op* op) override;
grpc_endpoint* GetEndpoint() override { return nullptr; }
size_t SizeOfStream() const override;
void InitStream(grpc_stream* gs, grpc_stream_refcount* refcount,
const void* server_data, grpc_core::Arena* arena) override;

@ -85,7 +85,6 @@ class InprocServerTransport final : public ServerTransport {
Crash("set_accept_stream not supported on inproc transport");
}
}
grpc_endpoint* GetEndpoint() override { return nullptr; }
void Disconnect(absl::Status error) {
if (disconnecting_.exchange(true, std::memory_order_relaxed)) return;
@ -162,7 +161,6 @@ class InprocClientTransport final : public ClientTransport {
void SetPollset(grpc_stream*, grpc_pollset*) override {}
void SetPollsetSet(grpc_stream*, grpc_pollset_set*) override {}
void PerformOp(grpc_transport_op*) override { Crash("unimplemented"); }
grpc_endpoint* GetEndpoint() override { return nullptr; }
private:
~InprocClientTransport() override {

@ -135,7 +135,6 @@ struct inproc_transport final : public grpc_core::FilterStackTransport {
void SetPollsetSet(grpc_stream* stream,
grpc_pollset_set* pollset_set) override;
void PerformOp(grpc_transport_op* op) override;
grpc_endpoint* GetEndpoint() override;
size_t SizeOfStream() const override;
bool HackyDisableStreamOpBatchCoalescingInConnectedChannel() const override {
@ -1214,8 +1213,6 @@ void inproc_transport::SetPollsetSet(grpc_stream* /*gs*/,
// Nothing to do here
}
grpc_endpoint* inproc_transport::GetEndpoint() { return nullptr; }
//******************************************************************************
// Main inproc transport functions
//

@ -565,9 +565,6 @@ class Transport : public InternallyRefCounted<Transport> {
op->disconnect_with_error = error;
PerformOp(op);
}
// implementation of grpc_transport_get_endpoint
virtual grpc_endpoint* GetEndpoint() = 0;
};
class FilterStackTransport : public Transport {

@ -74,7 +74,6 @@ class FakeTransport final : public grpc_core::Transport {
void SetPollset(grpc_stream*, grpc_pollset*) override {}
void SetPollsetSet(grpc_stream*, grpc_pollset_set*) override {}
void PerformOp(grpc_transport_op*) override {}
grpc_endpoint* GetEndpoint() override { return nullptr; }
void Orphan() override {}
private:

@ -84,7 +84,6 @@ class FakeTransport final : public Transport {
void SetPollset(grpc_stream*, grpc_pollset*) override {}
void SetPollsetSet(grpc_stream*, grpc_pollset_set*) override {}
void PerformOp(grpc_transport_op*) override {}
grpc_endpoint* GetEndpoint() override { return nullptr; }
void Orphan() override {}
};
} // namespace

Loading…
Cancel
Save