Address reviewer comments

reviewable/pr16646/r11
Vijay Pai 6 years ago
parent 74fc60e9af
commit 17fc4d4029
  1. 2
      include/grpc/impl/codegen/grpc_types.h
  2. 2
      include/grpcpp/impl/codegen/callback_common.h

@ -669,7 +669,7 @@ typedef struct grpc_experimental_completion_queue_functor {
/** The run member specifies a function that will be called when this
tag is extracted from the completion queue. Its arguments will be a
pointer to this functor and a boolean that indicates whether the
success status of this operation */
operation succeeded (non-zero) or failed (zero) */
void (*functor_run)(struct grpc_experimental_completion_queue_functor*, int);
} grpc_experimental_completion_queue_functor;

@ -66,7 +66,7 @@ class CallbackWithStatusTag
CallbackWithStatusTag(grpc_call* call, std::function<void(Status)> f,
CompletionQueueTag* ops)
: call_(call), func_(std::move(f)), ops_(ops), status_() {
: call_(call), func_(std::move(f)), ops_(ops) {
g_core_codegen_interface->grpc_call_ref(call);
functor_run = &CallbackWithStatusTag::StaticRun;
}

Loading…
Cancel
Save