Remove unused parameter warning (15 of 20)

pull/20646/head
Vijay Pai 6 years ago
parent a0ad4081cb
commit 176dfc2289
  1. 4
      test/cpp/end2end/async_end2end_test.cc
  2. 4
      test/cpp/end2end/client_callback_end2end_test.cc
  3. 2
      test/cpp/end2end/client_crash_test_server.cc
  4. 2
      test/cpp/end2end/client_interceptors_end2end_test.cc
  5. 2
      test/cpp/end2end/delegating_channel_test.cc
  6. 2
      test/cpp/end2end/end2end_test.cc
  7. 11
      test/cpp/end2end/exception_test.cc
  8. 4
      test/cpp/end2end/filter_end2end_test.cc
  9. 16
      test/cpp/end2end/hybrid_end2end_test.cc
  10. 8
      test/cpp/end2end/interceptors_util.h

@ -208,7 +208,7 @@ bool plugin_has_sync_methods(std::unique_ptr<ServerBuilderPlugin>& plugin) {
// that needs to be tested here. // that needs to be tested here.
class ServerBuilderSyncPluginDisabler : public ::grpc::ServerBuilderOption { class ServerBuilderSyncPluginDisabler : public ::grpc::ServerBuilderOption {
public: public:
void UpdateArguments(ChannelArguments* arg) override {} void UpdateArguments(ChannelArguments* /*arg*/) override {}
void UpdatePlugins( void UpdatePlugins(
std::vector<std::unique_ptr<ServerBuilderPlugin>>* plugins) override { std::vector<std::unique_ptr<ServerBuilderPlugin>>* plugins) override {
@ -1821,7 +1821,7 @@ TEST_P(AsyncEnd2endServerTryCancelTest, ServerBidiStreamingTryCancelAfter) {
TestBidiStreamingServerCancel(CANCEL_AFTER_PROCESSING); TestBidiStreamingServerCancel(CANCEL_AFTER_PROCESSING);
} }
std::vector<TestScenario> CreateTestScenarios(bool test_secure, std::vector<TestScenario> CreateTestScenarios(bool /*test_secure*/,
bool test_message_size_limit) { bool test_message_size_limit) {
std::vector<TestScenario> scenarios; std::vector<TestScenario> scenarios;
std::vector<grpc::string> credentials_types; std::vector<grpc::string> credentials_types;

@ -326,8 +326,8 @@ class ClientCallbackEnd2endTest
}; };
activate_(); activate_();
} }
void OnWriteDone(bool ok) override { StartWritesDone(); } void OnWriteDone(bool /*ok*/) override { StartWritesDone(); }
void OnReadDone(bool ok) override { void OnReadDone(bool /*ok*/) override {
EchoResponse response; EchoResponse response;
EXPECT_TRUE(ParseFromByteBuffer(&recv_buf_, &response)); EXPECT_TRUE(ParseFromByteBuffer(&recv_buf_, &response));
EXPECT_EQ(request_.message(), response.message()); EXPECT_EQ(request_.message(), response.message());

@ -46,7 +46,7 @@ namespace testing {
class ServiceImpl final : public ::grpc::testing::EchoTestService::Service { class ServiceImpl final : public ::grpc::testing::EchoTestService::Service {
Status BidiStream( Status BidiStream(
ServerContext* context, ServerContext* /*context*/,
ServerReaderWriter<EchoResponse, EchoRequest>* stream) override { ServerReaderWriter<EchoResponse, EchoRequest>* stream) override {
EchoRequest request; EchoRequest request;
EchoResponse response; EchoResponse response;

@ -507,7 +507,7 @@ class BidiStreamingRpcHijackingInterceptorFactory
// single RPC should be made on the channel before calling the Verify methods. // single RPC should be made on the channel before calling the Verify methods.
class LoggingInterceptor : public experimental::Interceptor { class LoggingInterceptor : public experimental::Interceptor {
public: public:
LoggingInterceptor(experimental::ClientRpcInfo* info) { LoggingInterceptor(experimental::ClientRpcInfo* /*info*/) {
pre_send_initial_metadata_ = false; pre_send_initial_metadata_ = false;
pre_send_message_count_ = 0; pre_send_message_count_ = 0;
pre_send_close_ = false; pre_send_close_ = false;

@ -48,7 +48,7 @@ class TestChannel : public experimental::DelegatingChannel {
TestChannel(const std::shared_ptr<ChannelInterface>& delegate_channel) TestChannel(const std::shared_ptr<ChannelInterface>& delegate_channel)
: experimental::DelegatingChannel(delegate_channel) {} : experimental::DelegatingChannel(delegate_channel) {}
// Always returns GRPC_CHANNEL_READY // Always returns GRPC_CHANNEL_READY
grpc_connectivity_state GetState(bool try_to_connect) override { grpc_connectivity_state GetState(bool /*try_to_connect*/) override {
return GRPC_CHANNEL_READY; return GRPC_CHANNEL_READY;
} }
}; };

@ -212,7 +212,7 @@ class Proxy : public ::grpc::testing::EchoTestService::Service {
class TestServiceImplDupPkg class TestServiceImplDupPkg
: public ::grpc::testing::duplicate::EchoTestService::Service { : public ::grpc::testing::duplicate::EchoTestService::Service {
public: public:
Status Echo(ServerContext* context, const EchoRequest* request, Status Echo(ServerContext* /*context*/, const EchoRequest* /*request*/,
EchoResponse* response) override { EchoResponse* response) override {
response->set_message("no package"); response->set_message("no package");
return Status::OK; return Status::OK;

@ -39,13 +39,14 @@ const char* kErrorMessage = "This service caused an exception";
#if GRPC_ALLOW_EXCEPTIONS #if GRPC_ALLOW_EXCEPTIONS
class ExceptingServiceImpl : public ::grpc::testing::EchoTestService::Service { class ExceptingServiceImpl : public ::grpc::testing::EchoTestService::Service {
public: public:
Status Echo(ServerContext* server_context, const EchoRequest* request, Status Echo(ServerContext* /*server_context*/,
EchoResponse* response) override { const EchoRequest* /*request*/,
EchoResponse* /*response*/) override {
throw - 1; throw - 1;
} }
Status RequestStream(ServerContext* context, Status RequestStream(ServerContext* /*context*/,
ServerReader<EchoRequest>* reader, ServerReader<EchoRequest>* /*reader*/,
EchoResponse* response) override { EchoResponse* /*response*/) override {
throw ServiceException(); throw ServiceException();
} }

@ -99,8 +99,8 @@ int GetCallCounterValue() {
class ChannelDataImpl : public ChannelData { class ChannelDataImpl : public ChannelData {
public: public:
grpc_error* Init(grpc_channel_element* elem, grpc_error* Init(grpc_channel_element* /*elem*/,
grpc_channel_element_args* args) { grpc_channel_element_args* /*args*/) {
IncrementConnectionCounter(); IncrementConnectionCounter();
return GRPC_ERROR_NONE; return GRPC_ERROR_NONE;
} }

@ -80,7 +80,7 @@ void HandleEcho(Service* service, ServerCompletionQueue* cq, bool dup_service) {
// that the req/resp are ByteBuffers // that the req/resp are ByteBuffers
template <class Service> template <class Service>
void HandleRawEcho(Service* service, ServerCompletionQueue* cq, void HandleRawEcho(Service* service, ServerCompletionQueue* cq,
bool dup_service) { bool /*dup_service*/) {
ServerContext srv_ctx; ServerContext srv_ctx;
GenericServerAsyncResponseWriter response_writer(&srv_ctx); GenericServerAsyncResponseWriter response_writer(&srv_ctx);
ByteBuffer recv_buffer; ByteBuffer recv_buffer;
@ -219,7 +219,7 @@ void HandleGenericCall(AsyncGenericService* service,
class TestServiceImplDupPkg class TestServiceImplDupPkg
: public ::grpc::testing::duplicate::EchoTestService::Service { : public ::grpc::testing::duplicate::EchoTestService::Service {
public: public:
Status Echo(ServerContext* context, const EchoRequest* request, Status Echo(ServerContext* /*context*/, const EchoRequest* request,
EchoResponse* response) override { EchoResponse* response) override {
response->set_message(request->message() + "_dup"); response->set_message(request->message() + "_dup");
return Status::OK; return Status::OK;
@ -566,7 +566,7 @@ class StreamedUnaryDupPkg
TestServiceImplDupPkg> { TestServiceImplDupPkg> {
public: public:
Status StreamedEcho( Status StreamedEcho(
ServerContext* context, ServerContext* /*context*/,
ServerUnaryStreamer<EchoRequest, EchoResponse>* stream) override { ServerUnaryStreamer<EchoRequest, EchoResponse>* stream) override {
EchoRequest req; EchoRequest req;
EchoResponse resp; EchoResponse resp;
@ -604,7 +604,7 @@ class FullyStreamedUnaryDupPkg
: public duplicate::EchoTestService::StreamedUnaryService { : public duplicate::EchoTestService::StreamedUnaryService {
public: public:
Status StreamedEcho( Status StreamedEcho(
ServerContext* context, ServerContext* /*context*/,
ServerUnaryStreamer<EchoRequest, EchoResponse>* stream) override { ServerUnaryStreamer<EchoRequest, EchoResponse>* stream) override {
EchoRequest req; EchoRequest req;
EchoResponse resp; EchoResponse resp;
@ -643,7 +643,7 @@ class SplitResponseStreamDupPkg
WithSplitStreamingMethod_ResponseStream<TestServiceImplDupPkg> { WithSplitStreamingMethod_ResponseStream<TestServiceImplDupPkg> {
public: public:
Status StreamedResponseStream( Status StreamedResponseStream(
ServerContext* context, ServerContext* /*context*/,
ServerSplitStreamer<EchoRequest, EchoResponse>* stream) override { ServerSplitStreamer<EchoRequest, EchoResponse>* stream) override {
EchoRequest req; EchoRequest req;
EchoResponse resp; EchoResponse resp;
@ -683,7 +683,7 @@ class FullySplitStreamedDupPkg
: public duplicate::EchoTestService::SplitStreamedService { : public duplicate::EchoTestService::SplitStreamedService {
public: public:
Status StreamedResponseStream( Status StreamedResponseStream(
ServerContext* context, ServerContext* /*context*/,
ServerSplitStreamer<EchoRequest, EchoResponse>* stream) override { ServerSplitStreamer<EchoRequest, EchoResponse>* stream) override {
EchoRequest req; EchoRequest req;
EchoResponse resp; EchoResponse resp;
@ -722,7 +722,7 @@ TEST_F(HybridEnd2endTest,
class FullyStreamedDupPkg : public duplicate::EchoTestService::StreamedService { class FullyStreamedDupPkg : public duplicate::EchoTestService::StreamedService {
public: public:
Status StreamedEcho( Status StreamedEcho(
ServerContext* context, ServerContext* /*context*/,
ServerUnaryStreamer<EchoRequest, EchoResponse>* stream) override { ServerUnaryStreamer<EchoRequest, EchoResponse>* stream) override {
EchoRequest req; EchoRequest req;
EchoResponse resp; EchoResponse resp;
@ -735,7 +735,7 @@ class FullyStreamedDupPkg : public duplicate::EchoTestService::StreamedService {
return Status::OK; return Status::OK;
} }
Status StreamedResponseStream( Status StreamedResponseStream(
ServerContext* context, ServerContext* /*context*/,
ServerSplitStreamer<EchoRequest, EchoResponse>* stream) override { ServerSplitStreamer<EchoRequest, EchoResponse>* stream) override {
EchoRequest req; EchoRequest req;
EchoResponse resp; EchoResponse resp;

@ -72,12 +72,12 @@ class DummyInterceptorFactory
public experimental::ServerInterceptorFactoryInterface { public experimental::ServerInterceptorFactoryInterface {
public: public:
virtual experimental::Interceptor* CreateClientInterceptor( virtual experimental::Interceptor* CreateClientInterceptor(
experimental::ClientRpcInfo* info) override { experimental::ClientRpcInfo* /*info*/) override {
return new DummyInterceptor(); return new DummyInterceptor();
} }
virtual experimental::Interceptor* CreateServerInterceptor( virtual experimental::Interceptor* CreateServerInterceptor(
experimental::ServerRpcInfo* info) override { experimental::ServerRpcInfo* /*info*/) override {
return new DummyInterceptor(); return new DummyInterceptor();
} }
}; };
@ -88,12 +88,12 @@ class NullInterceptorFactory
public experimental::ServerInterceptorFactoryInterface { public experimental::ServerInterceptorFactoryInterface {
public: public:
virtual experimental::Interceptor* CreateClientInterceptor( virtual experimental::Interceptor* CreateClientInterceptor(
experimental::ClientRpcInfo* info) override { experimental::ClientRpcInfo* /*info*/) override {
return nullptr; return nullptr;
} }
virtual experimental::Interceptor* CreateServerInterceptor( virtual experimental::Interceptor* CreateServerInterceptor(
experimental::ServerRpcInfo* info) override { experimental::ServerRpcInfo* /*info*/) override {
return nullptr; return nullptr;
} }
}; };

Loading…
Cancel
Save