Remove the TaskHandle return type from EventEngine::Run (#27269)

It isn't used in gRPC currently, and would be difficult to implement
efficiently in some scenarios.
pull/27220/head
AJ Heller 3 years ago committed by GitHub
parent 205445ffc6
commit 17174976b6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 7
      include/grpc/event_engine/event_engine.h
  2. 1
      src/core/lib/iomgr/event_engine/iomgr.cc

@ -286,9 +286,10 @@ class EventEngine {
/// Run a callback as soon as possible.
///
/// The \a fn callback's \a status argument is used to indicate whether it was
/// executed normally. For example, the status may be CANCELLED if
/// \a TryCancel was called, or if the EventEngine is being shut down.
virtual TaskHandle Run(Callback fn, RunOptions opts) = 0;
/// executed normally. For example, the status may be CANCELLED if the
/// EventEngine is being shut down. \a fn is guaranteed to be called exactly
/// once.
virtual void Run(Callback fn, RunOptions opts) = 0;
/// Synonymous with scheduling an alarm to run at time \a when.
///
/// The callback \a fn will execute when either when time \a when arrives

@ -41,7 +41,6 @@ namespace {
using ::grpc_event_engine::experimental::DefaultEventEngineFactory;
using ::grpc_event_engine::experimental::EventEngine;
using ::grpc_event_engine::experimental::Promise;
EventEngine* g_event_engine = nullptr;

Loading…
Cancel
Save